Make mojo_system static and mojo_system_impl a component, never use both

mojo/embedder/test_embedder.cc

Index: mojo/embedder/test_embedder.cc
diff --git a/mojo/embedder/test_embedder.cc b/mojo/embedder/test_embedder.cc
index 855d1da4feecbc02a19a19a392c1d7e77cb9814f..ec3a780e1bbfb1f3b7c179eb0a08f8c4850c82f7 100644
--- a/mojo/embedder/test_embedder.cc
+++ b/mojo/embedder/test_embedder.cc
@@ -6,7 +6,7 @@
 
 #include "base/logging.h"
 #include "base/macros.h"
-#include "mojo/system/core_impl.h"
+#include "mojo/system/core.h"
 #include "mojo/system/handle_table.h"
 
 namespace mojo {
@@ -14,7 +14,7 @@ namespace mojo {
 namespace system {
 namespace internal {
 
-bool ShutdownCheckNoLeaks(CoreImpl* core_impl) {
+bool ShutdownCheckNoLeaks(Core* core_impl) {
   // No point in taking the lock.
   const HandleTable::HandleToEntryMap& handle_to_entry_map =
       core_impl->handle_table_.handle_to_entry_map_;
@@ -38,12 +38,11 @@ namespace embedder {
 namespace test {
 
 bool Shutdown() {
-  system::CoreImpl* core_impl = static_cast<system::CoreImpl*>(Core::Get());
-  CHECK(core_impl);
-  Core::Reset();

[viettrungluu, 2014/04/09 23:06:44]

This line is important.

[DaveMoore, 2014/04/10 18:58:58]

Modified it to use the new entrypoints::Get/SetCore
On 2014/04/09 23:06:44, viettrungluu wrote:

+  system::Core* core = system::Core::GetInstance();
+  CHECK(core);
 
-  bool rv = system::internal::ShutdownCheckNoLeaks(core_impl);
-  delete core_impl;
+  bool rv = system::internal::ShutdownCheckNoLeaks(core);
+  delete core;
   return rv;
 }