Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1834)

Unified Diff: mojo/system/handle_table.h

Issue 231353002: Make mojo_system static and mojo_system_impl a component, never use both (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Cleanup Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/system/handle_table.h
diff --git a/mojo/system/handle_table.h b/mojo/system/handle_table.h
index 4bcf02c00402605211ad7ab413d925820a03eb24..16715e1c21e47d9317e922d5a2a267c2a0e6bc5c 100644
--- a/mojo/system/handle_table.h
+++ b/mojo/system/handle_table.h
@@ -17,21 +17,21 @@
namespace mojo {
namespace system {
-class CoreImpl;
+class Core;
class Dispatcher;
class DispatcherTransport;
// Test-only function (defined/used in embedder/test_embedder.cc). Declared here
// so it can be friended.
namespace internal {
-bool ShutdownCheckNoLeaks(CoreImpl*);
+bool ShutdownCheckNoLeaks(Core*);
}
-// This class provides the (global) handle table (owned by |CoreImpl|), which
+// This class provides the (global) handle table (owned by |Core|), which
viettrungluu 2014/04/09 20:26:52 Nit: Please re-wrap this paragraph, and the next o
DaveMoore 2014/04/09 22:49:08 Done.
// maps (valid) |MojoHandle|s to |Dispatcher|s. This is abstracted so that,
// e.g., caching may be added.
//
-// This class is NOT thread-safe; locking is left to |CoreImpl| (since it may
+// This class is NOT thread-safe; locking is left to |Core| (since it may
// need to make several changes -- "atomically" or in rapid successsion, in
// which case the extra locking/unlocking would be unnecessary overhead).
@@ -44,7 +44,7 @@ class MOJO_SYSTEM_IMPL_EXPORT HandleTable {
// |MOJO_HANDLE_INVALID|). Returns null if there's no dispatcher for the given
// handle.
// WARNING: For efficiency, this returns a dumb pointer. If you're going to
- // use the result outside |CoreImpl|'s lock, you MUST take a reference (e.g.,
+ // use the result outside |Core|'s lock, you MUST take a reference (e.g.,
viettrungluu 2014/04/09 20:26:52 "
DaveMoore 2014/04/09 22:49:08 Done.
// by storing the result inside a |scoped_refptr|).
Dispatcher* GetDispatcher(MojoHandle handle);
@@ -98,7 +98,7 @@ class MOJO_SYSTEM_IMPL_EXPORT HandleTable {
void RestoreBusyHandles(const MojoHandle* handles, uint32_t num_handles);
private:
- friend bool internal::ShutdownCheckNoLeaks(CoreImpl*);
+ friend bool internal::ShutdownCheckNoLeaks(Core*);
struct Entry {
Entry();

Powered by Google App Engine
This is Rietveld 408576698