Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Side by Side Diff: Source/modules/webmidi/MIDIOutput.cpp

Issue 23135009: Improve IDB module's SecurityError messages. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: test Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 13 matching lines...) Expand all
24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 24 * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 25 * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "modules/webmidi/MIDIOutput.h" 32 #include "modules/webmidi/MIDIOutput.h"
33 33
34 #include "bindings/v8/ExceptionMessages.h"
34 #include "bindings/v8/ExceptionState.h" 35 #include "bindings/v8/ExceptionState.h"
35 #include "core/dom/ExceptionCode.h" 36 #include "core/dom/ExceptionCode.h"
36 #include "modules/webmidi/MIDIAccess.h" 37 #include "modules/webmidi/MIDIAccess.h"
37 38
38 namespace WebCore { 39 namespace WebCore {
39 40
40 PassRefPtr<MIDIOutput> MIDIOutput::create(MIDIAccess* access, unsigned portIndex , ScriptExecutionContext* context, const String& id, const String& manufacturer, const String& name, const String& version) 41 PassRefPtr<MIDIOutput> MIDIOutput::create(MIDIAccess* access, unsigned portIndex , ScriptExecutionContext* context, const String& id, const String& manufacturer, const String& name, const String& version)
41 { 42 {
42 return adoptRef(new MIDIOutput(access, portIndex, context, id, manufacturer, name, version)); 43 return adoptRef(new MIDIOutput(access, portIndex, context, id, manufacturer, name, version));
43 } 44 }
(...skipping 14 matching lines...) Expand all
58 { 59 {
59 if (!array) 60 if (!array)
60 return; 61 return;
61 62
62 const unsigned char* data = array->data(); 63 const unsigned char* data = array->data();
63 size_t length = array->length(); 64 size_t length = array->length();
64 65
65 // Filter out System Exclusive messages if we're not allowed. 66 // Filter out System Exclusive messages if we're not allowed.
66 // FIXME: implement more extensive filtering. 67 // FIXME: implement more extensive filtering.
67 if (length > 0 && data[0] >= 0xf0 && !m_access->sysExEnabled()) { 68 if (length > 0 && data[0] >= 0xf0 && !m_access->sysExEnabled()) {
68 es.throwDOMException(SecurityError); 69 es.throwSecurityError(ExceptionMessages::failedToExecute("send", "MIDIOu tput", "permission to send system exclusive messages is denied."));
69 return; 70 return;
70 } 71 }
71 72
72 m_access->sendMIDIData(m_portIndex, data, length, timestamp); 73 m_access->sendMIDIData(m_portIndex, data, length, timestamp);
73 } 74 }
74 75
75 void MIDIOutput::send(Vector<unsigned> unsignedData, double timestamp, Exception State& es) 76 void MIDIOutput::send(Vector<unsigned> unsignedData, double timestamp, Exception State& es)
76 { 77 {
77 RefPtr<Uint8Array> array = Uint8Array::create(unsignedData.size()); 78 RefPtr<Uint8Array> array = Uint8Array::create(unsignedData.size());
78 79
(...skipping 13 matching lines...) Expand all
92 { 93 {
93 send(data, 0, es); 94 send(data, 0, es);
94 } 95 }
95 96
96 void MIDIOutput::send(Vector<unsigned> unsignedData, ExceptionState& es) 97 void MIDIOutput::send(Vector<unsigned> unsignedData, ExceptionState& es)
97 { 98 {
98 send(unsignedData, 0, es); 99 send(unsignedData, 0, es);
99 } 100 }
100 101
101 } // namespace WebCore 102 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698