Modify the rebaselining logic to handle skipped tests.

Modify the rebaselining logic to handle skipped tests.

One of the first steps when rebaselining results for a test
is to push the existing baseline further down in the tree so that
other ports are not affected when the baseline is updated. However,
if a port further down in the tree skips the test, it doesn't want the
new baseline. Fixing this will keep the Android port from getting a lot
of unwanted baselines while we're bringing back up to date.

R=ojan@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156285

[Dirk Pranke, 2013-08-19 05:40:52]

https://codereview.chromium.org/23135008/diff/1/Tools/Scripts/webkitpy/tool/c...
File Tools/Scripts/webkitpy/tool/commands/rebaseline.py (right):

https://codereview.chromium.org/23135008/diff/1/Tools/Scripts/webkitpy/tool/c...
Tools/Scripts/webkitpy/tool/commands/rebaseline.py:156: if SKIP in
expectations.get_expectations(test_name):
Ojan, do I need any other expectations in here (in particular, WontFix), or are
the other ones all still modifiers?

[ojan, 2013-08-19 06:05:27]

lgtm

https://codereview.chromium.org/23135008/diff/1/Tools/Scripts/webkitpy/tool/c...
File Tools/Scripts/webkitpy/tool/commands/rebaseline.py (right):

https://codereview.chromium.org/23135008/diff/1/Tools/Scripts/webkitpy/tool/c...
Tools/Scripts/webkitpy/tool/commands/rebaseline.py:156: if SKIP in
expectations.get_expectations(test_name):
On 2013/08/19 05:40:52, Dirk Pranke wrote:
> Ojan, do I need any other expectations in here (in particular, WontFix), or
are
> the other ones all still modifiers?

If it's WontFix, we artificially add Skip at the moment. I tried to change that
at one point and gave up. So, not sure if this should have a FIXME...but it
works for now.

[commit-bot: I haz the power, 2013-08-19 06:05:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dpranke@chromium.org/23135008/1

[commit-bot: I haz the power, 2013-08-19 07:17:51]

Change committed as 156285