Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(330)

Issue 2313403002: Revert of Fix GYP-based closure try bots while they continue getting ported to GN (Closed)

Created:
4 years, 3 months ago by Dan Beam
Modified:
4 years, 3 months ago
Reviewers:
agable, iannucci
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Revert of Fix GYP-based closure try bots while they continue getting ported to GN (patchset #6 id:100001 of https://codereview.chromium.org/2315123002/ ) Reason for revert: Hopefully reverting this fixes Closure Compilation Linux bots: https://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux They haven't been working since build/gyp_chromium was removed. Let's convert back to using that again now that build/gyp_chromium was restored temporarily. Original issue's description: > Fix GYP-based closure try bots while they continue getting ported to GN > > R=iannucci@chromium.org > BUG=644563 > > Committed: https://chromium.googlesource.com/chromium/tools/build/+/191bb2bd43d119b86f82d72a34dd65c86f0caa55 TBR=iannucci@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=644563 Committed: https://chromium.googlesource.com/chromium/tools/build/+/378036a294f1ead296e09284dc83387dcacedd1f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -8 lines) Patch
M scripts/slave/recipes/closure_compilation.py View 1 chunk +15 lines, -3 lines 0 comments Download
M scripts/slave/recipes/closure_compilation.expected/closure_compilation_fyi.json View 1 chunk +72 lines, -2 lines 0 comments Download
M scripts/slave/recipes/closure_compilation.expected/closure_compilation_try.json View 1 chunk +73 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Dan Beam
Created Revert of Fix GYP-based closure try bots while they continue getting ported to GN
4 years, 3 months ago (2016-09-07 16:43:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313403002/1
4 years, 3 months ago (2016-09-07 16:43:54 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 3 months ago (2016-09-07 16:43:55 UTC) #5
agable
lgtm
4 years, 3 months ago (2016-09-07 17:00:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313403002/1
4 years, 3 months ago (2016-09-07 17:00:24 UTC) #13
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 17:00:37 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/378036a294f1ead296e0...

Powered by Google App Engine
This is Rietveld 408576698