Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Unified Diff: src/js/string.js

Issue 2313393005: [builtins] Move StringLocaleCompare to a builtin. (Closed)
Patch Set: Change dcheck to dcheck_eq Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/js/string.js
diff --git a/src/js/string.js b/src/js/string.js
index 00fee68ac9fc6d02598c212d89f9af54d135b84a..da1643b06c9c2fb787acbb99d76261ef72431706 100644
--- a/src/js/string.js
+++ b/src/js/string.js
@@ -87,17 +87,6 @@ function StringLastIndexOf(pat, pos) { // length == 1
%FunctionSetLength(StringLastIndexOf, 1);
-// ECMA-262 section 15.5.4.9
-//
-// This function is implementation specific. For now, we do not
-// do anything locale specific.
-function StringLocaleCompareJS(other) {
- CHECK_OBJECT_COERCIBLE(this, "String.prototype.localeCompare");
-
- return %StringLocaleCompare(TO_STRING(this), TO_STRING(other));
-}
-
-
// ES6 21.1.3.11.
function StringMatchJS(pattern) {
CHECK_OBJECT_COERCIBLE(this, "String.prototype.match");
@@ -714,7 +703,6 @@ utils.InstallFunctions(GlobalString.prototype, DONT_ENUM, [
"includes", StringIncludes,
"indexOf", StringIndexOf,
"lastIndexOf", StringLastIndexOf,
- "localeCompare", StringLocaleCompareJS,
"match", StringMatchJS,
"repeat", StringRepeat,
"replace", StringReplace,
« no previous file with comments | « src/builtins/builtins-string.cc ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698