[builtins] Move StringLocaleCompare to a builtin.

[builtins] Move StringLocaleCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
Committed: https://crrev.com/8ffbd333bbcc73f6dbae40ef501c2b1166b3cc05
Cr-Commit-Position: refs/heads/master@{#39347}

[petermarshall, 2016-09-09 14:01:20]

The CQ bit was checked by petermarshall@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-09 14:01:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 14:32:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 14:32:11]

Dry run: This issue passed the CQ dry run.

[petermarshall, 2016-09-12 09:08:19]

Description was changed from

==========
Move localeCompare to a builtin

BUG=v8:5364
==========

to

==========
Move localeCompare to a builtin
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

[petermarshall, 2016-09-12 09:50:04]

Description was changed from

==========
Move localeCompare to a builtin
CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

to

==========
Move localeCompare to a builtin
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

[petermarshall, 2016-09-12 10:28:59]

Description was changed from

==========
Move localeCompare to a builtin
CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

to

==========
Move localeCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

[petermarshall, 2016-09-12 10:38:32]

Description was changed from

==========
Move localeCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

to

==========
[builtins] Move localeCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

[petermarshall, 2016-09-12 10:38:54]

petermarshall@chromium.org changed reviewers:
+ bmeurer@chromium.org, franzih@chromium.org

[Franzi, 2016-09-12 10:57:23]

On 2016/09/12 at 10:38:55, petermarshall wrote:
> 

LGTM. But can we say StringLocaleCompare in the commit message?

[Benedikt Meurer, 2016-09-12 10:58:57]

LGTM once nit is addressed.

https://codereview.chromium.org/2313393005/diff/40001/src/builtins/builtins-s...
File src/builtins/builtins-string.cc (right):

https://codereview.chromium.org/2313393005/diff/40001/src/builtins/builtins-s...
src/builtins/builtins-string.cc:488: DCHECK(args.length() == 2);
Nit: DCHECK_EQ(2, args.length())

[petermarshall, 2016-09-12 11:02:02]

Description was changed from

==========
[builtins] Move localeCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

to

==========
[builtins] Move StringLocaleCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

[petermarshall, 2016-09-12 11:04:07]

The CQ bit was checked by petermarshall@chromium.org

[petermarshall, 2016-09-12 11:04:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, franzih@chromium.org
Link to the patchset: https://codereview.chromium.org/2313393005/#ps60001
(title: "Change dcheck to dcheck_eq")

[commit-bot: I haz the power, 2016-09-12 11:04:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 11:40:05]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-12 11:40:41]

Description was changed from

==========
[builtins] Move StringLocaleCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364
==========

to

==========
[builtins] Move StringLocaleCompare to a builtin.

CQ_INCLUDE_TRYBOTS=master.tryserver.v8:v8_linux_noi18n_rel_ng

BUG=v8:5364

Committed: https://crrev.com/8ffbd333bbcc73f6dbae40ef501c2b1166b3cc05
Cr-Commit-Position: refs/heads/master@{#39347}
==========

[commit-bot: I haz the power, 2016-09-12 11:40:42]

Patchset 4 (id:??) landed as
https://crrev.com/8ffbd333bbcc73f6dbae40ef501c2b1166b3cc05
Cr-Commit-Position: refs/heads/master@{#39347}