Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2313373002: Re-enable WebRTCAudioQualityTest on Windows. (Closed)

Created:
4 years, 3 months ago by ehmaldonado_chromium
Modified:
4 years, 3 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews, feature-media-reviews_chromium.org, tnakamura+watch_chromium.org, phoglund+watch_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable WebRTCAudioQualityTest on Windows. The bots seem to be correctly configured now. BUG=625808 Committed: https://crrev.com/0811707d83a76cb6abb7b436ffec1026079ff0a6 Cr-Commit-Position: refs/heads/master@{#417253}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/media/webrtc/webrtc_audio_quality_browsertest.cc View 1 2 chunks +2 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
ehmaldonado_chromium
I think I configured it correctly now.
4 years, 3 months ago (2016-09-07 15:35:30 UTC) #2
phoglund_chromium
lgtm
4 years, 3 months ago (2016-09-08 09:49:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313373002/1
4 years, 3 months ago (2016-09-08 09:59:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/65733) ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 3 months ago (2016-09-08 10:01:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313373002/20001
4 years, 3 months ago (2016-09-08 10:04:08 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 11:35:23 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-08 11:37:05 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0811707d83a76cb6abb7b436ffec1026079ff0a6
Cr-Commit-Position: refs/heads/master@{#417253}

Powered by Google App Engine
This is Rietveld 408576698