If ES3 EGL config selection fails, fall back to ES2.

If ES3 EGL config selection fails, fall back to ES2.

BUG=643362
Committed: https://crrev.com/d5d623aed82374fffde513ed8de88346a14aea42
Cr-Commit-Position: refs/heads/master@{#417267}

[Geoff Lang, 2016-09-07 14:53:40]

The CQ bit was checked by geofflang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 14:53:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Geoff Lang, 2016-09-07 14:56:14]

https://codereview.chromium.org/2313353002/diff/1/ui/gl/gl_surface_egl.cc
File ui/gl/gl_surface_egl.cc (right):

https://codereview.chromium.org/2313353002/diff/1/ui/gl/gl_surface_egl.cc#new...
ui/gl/gl_surface_egl.cc:295: EGLint config_attribs_8888[] = {EGL_BUFFER_SIZE,
This block produced a pretty bad diff, no changes except putting it in a loop
and using 'continue' after failed calls to ValidateEglConfig instead of erroring
right away.

[commit-bot: I haz the power, 2016-09-07 16:01:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 16:01:20]

Dry run: This issue passed the CQ dry run.

[Geoff Lang, 2016-09-07 16:05:26]

geofflang@chromium.org changed reviewers:
+ kbr@chromium.org, zmo@chromium.org

[Geoff Lang, 2016-09-07 16:05:27]

PTAL.  Tested by using --unsafe-es3-apis with --use-angle=d3d9 and verified it
fell back to ES2.

[Zhenyao Mo, 2016-09-07 17:15:46]

On 2016/09/07 16:05:27, Geoff Lang wrote:
> PTAL.  Tested by using --unsafe-es3-apis with --use-angle=d3d9 and verified it
> fell back to ES2.

non-owner lgtm

[Ken Russell (switch to Gerrit), 2016-09-07 18:43:23]

lgtm

How will this fallback be tested?

[Geoff Lang, 2016-09-07 21:04:49]

On 2016/09/07 18:43:23, Ken Russell wrote:
> lgtm
> 
> How will this fallback be tested?

I think the best test would be that when we move to requesting ES3 by default,
our tests that are unable to use ES3 (WebGL CTS using d3d9, for example)
continue to pass.

[Ken Russell (switch to Gerrit), 2016-09-07 23:10:20]

On 2016/09/07 21:04:49, Geoff Lang wrote:
> On 2016/09/07 18:43:23, Ken Russell wrote:
> > lgtm
> > 
> > How will this fallback be tested?
> 
> I think the best test would be that when we move to requesting ES3 by default,
> our tests that are unable to use ES3 (WebGL CTS using d3d9, for example)
> continue to pass.

OK, that sounds reasonable, as long as we don't short-circuit the attempt to
create the ES3 context when running on top of D3D9.

[Geoff Lang, 2016-09-08 13:06:01]

The CQ bit was checked by geofflang@chromium.org

[commit-bot: I haz the power, 2016-09-08 13:06:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 13:09:51]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 13:11:43]

Description was changed from

==========
If ES3 EGL config selection fails, fall back to ES2.

BUG=643362
==========

to

==========
If ES3 EGL config selection fails, fall back to ES2.

BUG=643362

Committed: https://crrev.com/d5d623aed82374fffde513ed8de88346a14aea42
Cr-Commit-Position: refs/heads/master@{#417267}
==========

[commit-bot: I haz the power, 2016-09-08 13:11:44]

Patchset 1 (id:??) landed as
https://crrev.com/d5d623aed82374fffde513ed8de88346a14aea42
Cr-Commit-Position: refs/heads/master@{#417267}