Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2313253003: Rename views::MdTextButton::CreateMdButton to just Create (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
Peter Beverloo, sky
CC:
chromium-reviews, asanka, sadrul, Matt Giuca, tfarina, oshima+watch_chromium.org, kalyank, dbeam+watch-downloads_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename views::MdTextButton::CreateMdButton to just Create BUG=none TBR=peter@chromium.org Committed: https://crrev.com/2fa30434c4ce2415d7f01386d613d50af63a0612 Cr-Commit-Position: refs/heads/master@{#417075}

Patch Set 1 #

Patch Set 2 : more renames #

Unified diffs Side-by-side diffs Delta from patch set Stats (+90 lines, -104 lines) Patch
M ash/common/system/chromeos/session/logout_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shell/lock_view.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/shell/widgets.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/shell/window_type_launcher.cc View 2 chunks +25 lines, -30 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view_md.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download/download_shelf_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/infobars/confirm_infobar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 4 chunks +6 lines, -6 lines 0 comments Download
M mash/example/window_type_launcher/window_type_launcher.cc View 1 2 chunks +24 lines, -30 lines 0 comments Download
M ui/app_list/views/search_result_actions_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/md_text_button.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/views/controls/button/md_text_button.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M ui/views/examples/button_example.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/examples/button_sticker_sheet.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/focus/focus_traversal_unittest.cc View 4 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Evan Stade
4 years, 3 months ago (2016-09-07 17:30:46 UTC) #2
sky
LGTM
4 years, 3 months ago (2016-09-07 17:41:09 UTC) #5
Evan Stade
+peter tbr for mechanical changes in content/shell
4 years, 3 months ago (2016-09-07 19:18:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313253003/20001
4 years, 3 months ago (2016-09-07 19:18:46 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-07 22:07:08 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 22:09:53 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/2fa30434c4ce2415d7f01386d613d50af63a0612
Cr-Commit-Position: refs/heads/master@{#417075}

Powered by Google App Engine
This is Rietveld 408576698