Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Side by Side Diff: src/counters-inl.h

Issue 2313193002: [Tracing] Fix runtime call stats tracing for GC. (Closed)
Patch Set: Remove duplicate runtime call stats in counters Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/counters.h ('k') | src/heap/gc-tracer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 the V8 project authors. All rights reserved. 1 // Copyright 2016 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_COUNTERS_INL_H_ 5 #ifndef V8_COUNTERS_INL_H_
6 #define V8_COUNTERS_INL_H_ 6 #define V8_COUNTERS_INL_H_
7 7
8 #include "src/counters.h" 8 #include "src/counters.h"
9 9
10 namespace v8 { 10 namespace v8 {
11 namespace internal { 11 namespace internal {
12 12
13 RuntimeCallTimerScope::RuntimeCallTimerScope( 13 RuntimeCallTimerScope::RuntimeCallTimerScope(
14 HeapObject* heap_object, RuntimeCallStats::CounterId counter_id) { 14 Isolate* isolate, RuntimeCallStats::CounterId counter_id) {
15 if (V8_UNLIKELY(FLAG_runtime_call_stats)) { 15 if (V8_UNLIKELY(TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_ENABLED() ||
16 isolate_ = heap_object->GetIsolate(); 16 FLAG_runtime_call_stats)) {
17 isolate_ = isolate;
17 RuntimeCallStats::Enter(isolate_->counters()->runtime_call_stats(), &timer_, 18 RuntimeCallStats::Enter(isolate_->counters()->runtime_call_stats(), &timer_,
18 counter_id); 19 counter_id);
19 } 20 }
20 // TODO(lpy): Add a tracing equivalent for the runtime call stats. 21 }
22
23 RuntimeCallTimerScope::RuntimeCallTimerScope(
24 HeapObject* heap_object, RuntimeCallStats::CounterId counter_id) {
25 if (V8_UNLIKELY(TRACE_EVENT_RUNTIME_CALL_STATS_TRACING_ENABLED() ||
26 FLAG_runtime_call_stats)) {
27 RuntimeCallTimerScope(heap_object->GetIsolate(), counter_id);
Camillo Bruni 2016/09/09 15:17:59 You'll ended up checking the flags twice this way
28 }
21 } 29 }
22 30
23 } // namespace internal 31 } // namespace internal
24 } // namespace v8 32 } // namespace v8
25 33
26 #endif // V8_COUNTERS_INL_H_ 34 #endif // V8_COUNTERS_INL_H_
OLDNEW
« no previous file with comments | « src/counters.h ('k') | src/heap/gc-tracer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698