Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 2313163002: Reland of ll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit). (Closed)

Created:
4 years, 3 months ago by nednguyen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, catapult-sheriff_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2310733002/ ) Reason for revert: Roll shouldn't be reverted. Original issue's description: > Revert of Roll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit). (patchset #1 id:1 of https://codereview.chromium.org/2311593002/ ) > > Reason for revert: > This appears to have broken the Google Chrome Win builder. > > Original issue's description: > > Roll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit). > > > > https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/4f812c9035e6..1f08948ad3a9 > > > > $ git log 4f812c903..1f08948ad --date=short --no-merges --format='%ad %ae %s' > > 2016-09-03 perezju [Telemetry] Expose platform.GetSystemTotalPhysicalMemory > > > > BUG=637217 > > > > TBR=catapult-sheriff@chromium.org > > > > Committed: https://crrev.com/62f4b56e57376b13a7bab82e50ca03c2d5033e63 > > Cr-Commit-Position: refs/heads/master@{#416456} > > TBR=catapult-sheriff@chromium.org,catapult-deps-roller@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=637217 > > Committed: https://crrev.com/233fa6caaa0206814af3213a04ffe27c914991ec > Cr-Commit-Position: refs/heads/master@{#416457} TBR=catapult-sheriff@chromium.org,catapult-deps-roller@chromium.org,sullivan@chromium.org,dominicc@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=637217

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
nednguyen
Created Reland of ll src/third_party/catapult/ 4f812c903..1f08948ad (1 commit).
4 years, 3 months ago (2016-09-06 23:07:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313163002/1
4 years, 3 months ago (2016-09-06 23:07:52 UTC) #3
dominicc (has gone to gerrit)
Why shouldn't rolls be reverted? I think this did break the windows build... Just out ...
4 years, 3 months ago (2016-09-12 05:37:43 UTC) #5
sullivan
4 years, 3 months ago (2016-09-12 12:00:43 UTC) #6
On 2016/09/12 05:37:43, dominicc wrote:
> Why shouldn't rolls be reverted? I think this did break the windows build...

If you just revert the roll, and don't stop the autoroller, it'll just re-roll
again. It's much better to revert the culprit CL inside the roll when possible.
Also please always link a bug when reverting a CL.

I'll work on getting some documentation in the CL descriptions.

> Just out of curiosity, why doesn't the roller use the commit queue?

It does use the commit queue.

Powered by Google App Engine
This is Rietveld 408576698