Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 2313123002: Harmony - set correct textfield placeholder text color (Closed)

Created:
4 years, 3 months ago by Evan Stade
Modified:
4 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, James Su, shuchen+watch_chromium.org, yusukes+watch_chromium.org, nona+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Harmony - set correct textfield placeholder text color Derive the placeholder text color from the normal text color instead of hardcoding or adding another constant to NativeTheme. This should handle unusual color schemes (like light text on a dark bg) well. In the normal case of \#333 default text on a white bg, this comes out to the spec'd value of \#969696. BUG=635160 Committed: https://crrev.com/1aeb79d7883f1f75729c452ece42137b991a0d40 Cr-Commit-Position: refs/heads/master@{#416843}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M ui/views/controls/textfield/textfield.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/textfield.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 13 (8 generated)
Evan Stade
4 years, 3 months ago (2016-09-07 00:09:20 UTC) #6
sky
LGTM
4 years, 3 months ago (2016-09-07 03:45:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313123002/1
4 years, 3 months ago (2016-09-07 04:10:28 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 04:13:52 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 04:15:54 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1aeb79d7883f1f75729c452ece42137b991a0d40
Cr-Commit-Position: refs/heads/master@{#416843}

Powered by Google App Engine
This is Rietveld 408576698