Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4949)

Unified Diff: chrome/browser/resources/settings/people_page/setup_pin_dialog.js

Issue 2313103002: Added uma for pin unlock set up. (Closed)
Patch Set: Closure compiler fix. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/people_page/setup_pin_dialog.js
diff --git a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
index 14da74e920079e25c9f623a7e76e97b124a5b19e..28748c004c5151caa0dba6892caeb65a3e88dcc2 100644
--- a/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
+++ b/chrome/browser/resources/settings/people_page/setup_pin_dialog.js
@@ -61,6 +61,18 @@ Polymer({
enableSubmit_: Boolean,
/**
+ * writeUma_ is a function that handles writing uma stats. It may be
+ * overridden for tests.
+ *
+ * @type {Function}
+ * @private
+ */
+ writeUma_: {
+ type: Object,
+ value: function() { return settings.recordLockScreenProgress; }
+ },
+
+ /**
* The current step/subpage we are on.
* @private
*/
@@ -210,6 +222,7 @@ Polymer({
this.isConfirmStep_ = true;
this.onPinChange_();
this.$.pinKeyboard.focus();
+ this.writeUma_(LockScreenProgress.ENTER_PIN);
}
} else {
// onPinSubmit_ gets called if the user hits enter on the PIN keyboard.
@@ -234,6 +247,7 @@ Polymer({
[chrome.quickUnlockPrivate.QuickUnlockMode.PIN],
[this.pinKeyboardValue_],
onSetModesCompleted.bind(this));
+ this.writeUma_(LockScreenProgress.CONFIRM_PIN);
}
},

Powered by Google App Engine
This is Rietveld 408576698