Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Side by Side Diff: chrome/browser/resources/settings/people_page/lock_screen_constants.js

Issue 2313103002: Added uma for pin unlock set up. (Closed)
Patch Set: Added tests. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 /**
6 * @fileoverview Constants used for logging the pin unlock setup uma.
7 */
8
9 /**
10 * Name of the pin unlock setup uma histogram.
11 * @type {string}
12 */
13 var PinUnlockUmaHistogramName = 'Settings.PinUnlockSetup';
14
15 /**
16 * Stages the user can enter while setting up pin unlock.
17 * @enum {number}
18 */
19 var LockScreenProgress = {
20 START_SCREEN_LOCK: 0,
21 ENTER_PASSWORD_CORRECTLY: 1,
22 CHOOSE_PIN_OR_PASSWORD: 2,
23 ENTER_PIN: 3,
24 CONFIRM_PIN: 4,
25 MAX_BUCKET: 5
26 };
27
28 /**
29 * Helper function to send the progress of the pin setup to be recorded in the
30 * histogram.
31 * @param {LockScreenProgress} currentProgress
32 */
33 var recordLockScreenProgress = function(currentProgress) {
Dan Beam 2016/12/16 08:31:01 maybe put this in a namespace? i.e. settings.reco
sammiequon 2016/12/17 18:17:13 Done.
34 if (currentProgress >= LockScreenProgress.MAX_BUCKET) {
35 console.error('Expected a enumeration value of ' +
36 LockScreenProgress.MAX_BUCKET + ' or lower: Received ' +
37 currentProgress + '.');
38 return;
39 }
40 chrome.send('metricsHandler:recordInHistogram',
41 [PinUnlockUmaHistogramName, currentProgress,
42 LockScreenProgress.MAX_BUCKET]);
43 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698