Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Side by Side Diff: chrome/browser/resources/options/browser_options.js

Issue 2313103002: Added uma for pin unlock set up. (Closed)
Patch Set: Fixed patch set 3 errors. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/options/compiled_resources.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.exportPath('options'); 5 cr.exportPath('options');
6 6
7 /** 7 /**
8 * @typedef {{actionLinkText: (string|undefined), 8 * @typedef {{actionLinkText: (string|undefined),
9 * childUser: (boolean|undefined), 9 * childUser: (boolean|undefined),
10 * hasError: (boolean|undefined), 10 * hasError: (boolean|undefined),
(...skipping 420 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 431
432 $('manage-accounts-button').onclick = function(event) { 432 $('manage-accounts-button').onclick = function(event) {
433 PageManager.showPageByName('accounts'); 433 PageManager.showPageByName('accounts');
434 chrome.send('coreOptionsUserMetricsAction', 434 chrome.send('coreOptionsUserMetricsAction',
435 ['Options_ManageAccounts']); 435 ['Options_ManageAccounts']);
436 }; 436 };
437 437
438 if (loadTimeData.getBoolean('showQuickUnlockSettings')) { 438 if (loadTimeData.getBoolean('showQuickUnlockSettings')) {
439 $('manage-screenlock').onclick = function(event) { 439 $('manage-screenlock').onclick = function(event) {
440 PageManager.showPageByName('quickUnlockConfigureOverlay'); 440 PageManager.showPageByName('quickUnlockConfigureOverlay');
441 recordLockScreenProgress(LockScreenProgress.START_SCREEN_LOCK);
Dan Beam 2016/09/16 21:43:15 where is this method included from? i don't see a
sammiequon 2016/09/17 00:08:15 I'm not quite sure where to add this file, is opti
Dan Beam 2016/09/17 00:36:03 how about a <script> or <link rel=import> in brows
sammiequon 2016/09/21 18:22:43 Done.
441 }; 442 };
442 $('manage-screenlock').hidden = false; 443 $('manage-screenlock').hidden = false;
443 } 444 }
444 } else { 445 } else {
445 $('import-data').onclick = function(event) { 446 $('import-data').onclick = function(event) {
446 ImportDataOverlay.show(); 447 ImportDataOverlay.show();
447 chrome.send('coreOptionsUserMetricsAction', ['Import_ShowDlg']); 448 chrome.send('coreOptionsUserMetricsAction', ['Import_ShowDlg']);
448 }; 449 };
449 450
450 if ($('themes-native-button')) { 451 if ($('themes-native-button')) {
(...skipping 1960 matching lines...) Expand 10 before | Expand all | Expand 10 after
2411 2412
2412 settings.hidden = !isVisible; 2413 settings.hidden = !isVisible;
2413 }; 2414 };
2414 } 2415 }
2415 2416
2416 // Export 2417 // Export
2417 return { 2418 return {
2418 BrowserOptions: BrowserOptions 2419 BrowserOptions: BrowserOptions
2419 }; 2420 };
2420 }); 2421 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/options/compiled_resources.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698