Timeline: always create filmstrip model and share single instance of it

Timeline: always create filmstrip model and share single instance of it

This makes FilmStripModel to be always created by TimelinePanel and passed
down to actual users.

Committed: https://crrev.com/1491aa14bfa3f1ddffc3684f74d8fa47aa472715
Cr-Commit-Position: refs/heads/master@{#419276}

[caseq, 2016-09-06 23:52:17]

Patchset #1 (id:1) has been deleted

[caseq, 2016-09-06 23:54:38]

caseq@chromium.org changed reviewers:
+ alph@chromium.org

[alph, 2016-09-08 00:03:07]

lgtm

https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js
(right):

https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js:29:
reset: function(tracingModel, zeroTime)
you don't need to pass tracingModel all the time. It doesn't change.
Also is zeroTime ever passed here?

https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
(right):

https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1041:
filmStripFrame = this._filmStripModel.frameByTimestamp(screenshotTime);
var ...

[caseq, 2016-09-08 01:17:24]

On 2016/09/08 00:03:07, alph wrote:
> lgtm
> 
>
https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
> File
> third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js
> (right):
> 
>
https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripModel.js:29:
> reset: function(tracingModel, zeroTime)
> you don't need to pass tracingModel all the time. It doesn't change.

I do, we don't keep it.

> Also is zeroTime ever passed here?

Yes, indirectly via constructor by NetworkPanel. In general, it you reset(), the
zero time is going to change.

> 
>
https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
> File third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js
> (right):
> 
>
https://codereview.chromium.org/2313093004/diff/20001/third_party/WebKit/Sour...
> third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js:1041:
> filmStripFrame = this._filmStripModel.frameByTimestamp(screenshotTime);
> var ...

Fixed, thanks for spotting.

[caseq, 2016-09-16 19:09:43]

The CQ bit was checked by caseq@chromium.org

[caseq, 2016-09-16 19:09:44]

The patchset sent to the CQ was uploaded after l-g-t-m from alph@chromium.org
Link to the patchset: https://codereview.chromium.org/2313093004/#ps40001
(title: "Timeline: always create filmstrip model")

[commit-bot: I haz the power, 2016-09-16 19:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 20:45:13]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-09-16 20:46:59]

Description was changed from

==========
Timeline: always create filmstrip model and share single instance of it

This makes FilmStripModel to be always created by TimelinePanel and passed
down to actual users.
==========

to

==========
Timeline: always create filmstrip model and share single instance of it

This makes FilmStripModel to be always created by TimelinePanel and passed
down to actual users.

Committed: https://crrev.com/1491aa14bfa3f1ddffc3684f74d8fa47aa472715
Cr-Commit-Position: refs/heads/master@{#419276}
==========

[commit-bot: I haz the power, 2016-09-16 20:47:00]

Patchset 2 (id:??) landed as
https://crrev.com/1491aa14bfa3f1ddffc3684f74d8fa47aa472715
Cr-Commit-Position: refs/heads/master@{#419276}