[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors:
1) unused StoreTransitionDescriptor is removed and VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack (dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not able
to deal with the stack allocated parameters in case of a stub failure.

TBR=jkummerow@chromium.org
BUG=v8:5269
Committed: https://crrev.com/130d989355d78c4c00e7f3c096bf23d9788162c3
Cr-Commit-Position: refs/heads/master@{#39476}

[Igor Sheludko, 2016-09-06 21:07:56]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: unused
StoreTransitionDescriptor is removed and VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.

BUG=
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: unused
StoreTransitionDescriptor is removed and VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.

BUG=
==========

[Igor Sheludko, 2016-09-06 21:09:35]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: unused
StoreTransitionDescriptor is removed and VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.

BUG=
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack

BUG=
==========

[Igor Sheludko, 2016-09-07 17:56:31]

Patchset #3 (id:40001) has been deleted

[Igor Sheludko, 2016-09-07 17:56:37]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2016-09-08 15:41:34]

Patchset #1 (id:1) has been deleted

[Igor Sheludko, 2016-09-08 15:42:56]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack

BUG=
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.
==========

[Igor Sheludko, 2016-09-08 17:43:23]

Patchset #5 (id:140001) has been deleted

[Igor Sheludko, 2016-09-08 17:43:31]

Patchset #3 (id:100001) has been deleted

[Igor Sheludko, 2016-09-08 17:43:39]

Patchset #2 (id:80001) has been deleted

[Igor Sheludko, 2016-09-08 17:43:47]

Patchset #1 (id:60001) has been deleted

[Igor Sheludko, 2016-09-08 17:45:49]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.

BUG=v8:5269
==========

[Igor Sheludko, 2016-09-08 17:50:23]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.

BUG=v8:5269
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.

These two stub ports has to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

BUG=v8:5269
==========

[Igor Sheludko, 2016-09-08 17:50:42]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.

These two stub ports has to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

BUG=v8:5269
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

BUG=v8:5269
==========

[Igor Sheludko, 2016-09-08 17:51:22]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 17:51:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 17:57:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 17:57:22]

Dry run: Try jobs failed on following builders:
  v8_win64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win64_rel_ng/builds/13920)
  v8_win_nosnap_shared_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_nosnap_shared_rel_ng...)

[Igor Sheludko, 2016-09-08 18:10:25]

Patchset #2 (id:160001) has been deleted

[Igor Sheludko, 2016-09-08 18:10:39]

Patchset #2 (id:180001) has been deleted

[Igor Sheludko, 2016-09-08 18:10:46]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 18:10:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 18:39:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 18:39:13]

Dry run: This issue passed the CQ dry run.

[Igor Sheludko, 2016-09-08 20:18:20]

ishell@chromium.org changed reviewers:
+ jkummerow@chromium.org

[Igor Sheludko, 2016-09-08 20:18:21]

PTAL. To ease the reviewing I split the CL into three independent parts, each in
its own patch set.

[Igor Sheludko, 2016-09-13 07:12:05]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-13 07:12:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-13 07:29:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-13 07:30:01]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Igor Sheludko, 2016-09-15 10:30:32]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack.

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

BUG=v8:5269
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

BUG=v8:5269
==========

[Igor Sheludko, 2016-09-15 10:38:00]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-15 10:38:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-09-15 10:57:26]

Patchset #1 (id:120001) has been deleted

[Igor Sheludko, 2016-09-15 10:57:35]

Patchset #1 (id:200001) has been deleted

[Igor Sheludko, 2016-09-15 10:57:48]

Patchset #1 (id:220001) has been deleted

[Igor Sheludko, 2016-09-15 10:58:00]

Patchset #1 (id:240001) has been deleted

[Igor Sheludko, 2016-09-15 11:04:33]

ishell@chromium.org changed reviewers:
+ mvstanton@chromium.org

[Igor Sheludko, 2016-09-15 11:04:34]

Michael, PTAL. To ease the reviewing I split the CL into three independent
parts, each in its own patch set.

[commit-bot: I haz the power, 2016-09-15 11:08:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-15 11:08:48]

Dry run: This issue passed the CQ dry run.

[mvstanton, 2016-09-16 13:24:06]

Nice cleanup!
LGTM.

https://codereview.chromium.org/2313093002/diff/300001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2313093002/diff/300001/src/code-stub-assemble...
src/code-stub-assembler.cc:4927: Comment("Not simple map change transition");
nit: "non-simple" might be better.

[mvstanton, 2016-09-16 13:30:44]

still lgtm after look at patchsets 1-2.

[mvstanton, 2016-09-16 13:30:45]

still lgtm after look at patchsets 1-2.

[mvstanton, 2016-09-16 13:30:47]

still lgtm after look at patchsets 1-2.

[Igor Sheludko, 2016-09-16 13:56:10]

Landing...

https://codereview.chromium.org/2313093002/diff/300001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2313093002/diff/300001/src/code-stub-assemble...
src/code-stub-assembler.cc:4927: Comment("Not simple map change transition");
On 2016/09/16 13:24:06, mvstanton wrote:
> nit: "non-simple" might be better.

Done.

[Igor Sheludko, 2016-09-16 13:56:17]

The CQ bit was checked by ishell@chromium.org

[Igor Sheludko, 2016-09-16 13:56:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
mvstanton@chromium.org
Link to the patchset: https://codereview.chromium.org/2313093002/#ps320001
(title: "Addressing comments")

[commit-bot: I haz the power, 2016-09-16 13:56:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-16 14:01:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-16 14:01:36]

Try jobs failed on following builders:
  v8_presubmit on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/24273)

[Igor Sheludko, 2016-09-16 14:03:43]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

BUG=v8:5269
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

TBR=bmeurer@chromium.org
BUG=v8:5269
==========

[Igor Sheludko, 2016-09-16 14:03:56]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2016-09-16 14:04:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2016-09-16 14:05:19]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

TBR=bmeurer@chromium.org
BUG=v8:5269
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

TBR=jkummerow@chromium.org
BUG=v8:5269
==========

[commit-bot: I haz the power, 2016-09-16 14:23:30]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

TBR=jkummerow@chromium.org
BUG=v8:5269
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

TBR=jkummerow@chromium.org
BUG=v8:5269
==========

[commit-bot: I haz the power, 2016-09-16 14:23:32]

Committed patchset #4 (id:320001)

[commit-bot: I haz the power, 2016-09-16 14:24:19]

Description was changed from

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors: 
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

TBR=jkummerow@chromium.org
BUG=v8:5269
==========

to

==========
[stubs] Port StoreTransitionStub and ElementsTransitionAndStoreStub to TurboFan.

This CL also cleans up related interface descriptors:
1) unused StoreTransitionDescriptor is removed and
VectorStoreTransitionDescriptor is
renamed to StoreTransitionDescriptor.
2) on ia32/x87 architectures slot and vector are passed on the stack
(dispatcher/handlers
cleanup will be addressed in a separate CL).

These two stub ports have to be combined in one CL because:
1) without changing the StoreTransitionDescriptor TF was not able to compile
them
on ia32/x87 (because of lack of registers),
2) it was not possible to change the descriptor first because Crankshaft was not
able
to deal with the stack allocated parameters in case of a stub failure.

TBR=jkummerow@chromium.org
BUG=v8:5269

Committed: https://crrev.com/130d989355d78c4c00e7f3c096bf23d9788162c3
Cr-Commit-Position: refs/heads/master@{#39476}
==========

[commit-bot: I haz the power, 2016-09-16 14:24:21]

Patchset 4 (id:??) landed as
https://crrev.com/130d989355d78c4c00e7f3c096bf23d9788162c3
Cr-Commit-Position: refs/heads/master@{#39476}

[danno, 2016-09-16 15:12:07]

danno@chromium.org changed reviewers:
+ danno@chromium.org

[danno, 2016-09-16 15:12:08]

Please use the tracking bug
https://bugs.chromium.org/p/chromium/issues/detail?id=608675 for CLs like this
that port Hydrogen stubs, since we have external developers who are interested
in our reduction of the number of code stubs generated by Crankshaft in order to
make porting V8 easier.

[Jakob Kummerow, 2016-09-21 22:53:35]

Two late comments, otherwise LGTM.

https://codereview.chromium.org/2313093002/diff/300001/src/code-stub-assemble...
File src/code-stub-assembler.cc (right):

https://codereview.chromium.org/2313093002/diff/300001/src/code-stub-assemble...
src/code-stub-assembler.cc:4980: // If the object is in new space, we need to
check whether it is and
nit: this sentence is a little garbled.

https://codereview.chromium.org/2313093002/diff/300001/src/code-stub-assemble...
src/code-stub-assembler.cc:4987: Branch(WordEqual(object_page,
memento_end_page), &map_check,
This is slightly imprecise, right? |memento_end| points right after the memento,
which may well be on the next page if the memento ends exactly at the page
boundary.