Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Issue 2313083002: Make CPDF_TextStateData private to CPDF_TextState. (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_TextStateData private to CPDF_TextState. Committed: https://pdfium.googlesource.com/pdfium/+/0a765b832c5b9dd0a46fb5a25ce09d52dedb336b

Patch Set 1 #

Patch Set 2 : Move loose functions to bottom #

Patch Set 3 : Don't memcpy in copy ctor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -211 lines) Patch
M BUILD.gn View 2 chunks +1 line, -3 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_graphicstates.h View 1 chunk +1 line, -1 line 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_textstate.h View 1 chunk +0 lines, -53 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_textstate.cpp View 1 2 2 chunks +98 lines, -1 line 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_textstatedata.cpp View 1 chunk +0 lines, -100 lines 0 comments Download
A core/fpdfapi/fpdf_page/include/cpdf_textstate.h View 1 1 chunk +91 lines, -0 lines 0 comments Download
D core/fpdfapi/fpdf_page/include/cpdf_textstatedata.h View 1 chunk +0 lines, -53 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-06 20:46:41 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-06 20:49:36 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313083002/20001
4 years, 3 months ago (2016-09-06 20:49:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2313083002/40001
4 years, 3 months ago (2016-09-06 21:06:45 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 21:51:43 UTC) #13
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/0a765b832c5b9dd0a46fb5a25ce09d52dedb...

Powered by Google App Engine
This is Rietveld 408576698