Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 23130007: Make gdb-add-index index concurrently. (Closed)

Created:
7 years, 4 months ago by awong
Modified:
7 years, 4 months ago
Reviewers:
piman
CC:
chromium-reviews, nasko, vrk (LEFT CHROMIUM)
Visibility:
Public.

Description

Make gdb-add-index index concurrently. Most linux machines can likely handle a few concurrent indexing jobs for the shared objects in one binary. This modification uses SIGUSR1 and subshells to simulate a semaphore with task queue that significantly increases the speed of execution over a newly built set of binaries. By default, this script executes 4 parallel indexing tasks, though the concurrency be controlled by setting the INDEX_TASKS shell variable. Here are bencharks from my z620, using a component build browser_test binary as the target: 6 threads browser_threads: real 0m36.307s user 0m51.680s sys 0m13.150s 4 threads browser_threads: real 0m39.243s user 0m53.010s sys 0m12.230s 1 thread browser_threads: real 1m12.099s user 0m53.300s sys 0m13.580s This was on an SSD. Benefit hit diminishing return after 4 threads and may actually taper off sooner. BUG=none R=piman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=217815

Patch Set 1 #

Patch Set 2 : Clean up comments slightly. #

Patch Set 3 : more comment fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -20 lines) Patch
M build/gdb-add-index View 1 2 2 chunks +104 lines, -20 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
awong
7 years, 4 months ago (2013-08-14 23:46:27 UTC) #1
piman
LGTM, though I think at this point python would probably be a better choice.
7 years, 4 months ago (2013-08-15 02:38:42 UTC) #2
awong
Committed patchset #3 manually as r217815 (presubmit successful).
7 years, 4 months ago (2013-08-15 18:03:07 UTC) #3
awong
7 years, 4 months ago (2013-08-15 18:03:31 UTC) #4
Message was sent while issue was closed.
On 2013/08/15 02:38:42, piman wrote:
> LGTM, though I think at this point python would probably be a better choice.

bah...python is for programmers. I'm a skript kiddie.

Powered by Google App Engine
This is Rietveld 408576698