MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all us…

MIPS: Never hchange nan-hole to hole or hole to nan-hole. Only allow changing hole to nan if all uses allow undefined as nan.

Port r16183 (1858bc57)

BUG=

Committed: https://code.google.com/p/v8/source/detail?r=16200

[palfia, 2013-08-14 21:55:41]

PTAL.

[Paul Lind, 2013-08-14 22:48:39]

LGTM, with the nitty rename request.

https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):

https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips...
src/mips/lithium-codegen-mips.cc:2325: __ MoveHigh(scratch, input_reg);
Please see note in macro-assembler-mips.h, I think this function should be
renamed.

https://codereview.chromium.org/23130006/diff/1/src/mips/macro-assembler-mips.h
File src/mips/macro-assembler-mips.h (right):

https://codereview.chromium.org/23130006/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.h:238: inline void MoveHigh(Register dst_high,
FPURegister src) {
I think we should rename these FmoveHigh/FmoveLow, to clearly indicate the FPU
functionality.

[palfia, 2013-08-14 23:04:16]

Fixed nits.

[palfia, 2013-08-14 23:05:44]

Thanks for the review, I've fixed the nits.

https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips.cc
File src/mips/lithium-codegen-mips.cc (right):

https://codereview.chromium.org/23130006/diff/1/src/mips/lithium-codegen-mips...
src/mips/lithium-codegen-mips.cc:2325: __ MoveHigh(scratch, input_reg);
On 2013/08/14 22:48:39, Paul Lind wrote:
> Please see note in macro-assembler-mips.h, I think this function should be
> renamed.

Done.

https://codereview.chromium.org/23130006/diff/1/src/mips/macro-assembler-mips.h
File src/mips/macro-assembler-mips.h (right):

https://codereview.chromium.org/23130006/diff/1/src/mips/macro-assembler-mips...
src/mips/macro-assembler-mips.h:238: inline void MoveHigh(Register dst_high,
FPURegister src) {
On 2013/08/14 22:48:39, Paul Lind wrote:
> I think we should rename these FmoveHigh/FmoveLow, to clearly indicate the FPU
> functionality.

Done.

[palfia, 2013-08-14 23:07:59]

Committed manually as r16200.