Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: trunk/src/tools/gn/header_checker.h

Issue 231293003: Revert 262747 "Improve GN public header file checking" (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « trunk/src/tools/gn/c_include_iterator_unittest.cc ('k') | trunk/src/tools/gn/header_checker.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/gn/header_checker.h
===================================================================
--- trunk/src/tools/gn/header_checker.h (revision 262754)
+++ trunk/src/tools/gn/header_checker.h (working copy)
@@ -18,9 +18,7 @@
#include "tools/gn/err.h"
class BuildSettings;
-class InputFile;
class Label;
-class LocationRange;
class SourceFile;
class Target;
@@ -73,13 +71,10 @@
Err* err) const;
// Checks that the given file in the given target can include the given
- // include file. If disallowed, returns false and sets the error. The
- // range indicates the location of the include in the file for error
- // reporting.
+ // include file. If disallowed, returns false and sets the error.
bool CheckInclude(const Target* from_target,
- const InputFile& source_file,
+ const SourceFile& source_file,
const SourceFile& include_file,
- const LocationRange& range,
Err* err) const;
// Returns true if the given search_for target is a dependency of
« no previous file with comments | « trunk/src/tools/gn/c_include_iterator_unittest.cc ('k') | trunk/src/tools/gn/header_checker.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698