Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2312923002: compare degenerates with tolerance (Closed)

Created:
4 years, 3 months ago by caryclark
Modified:
4 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

compare degenerates with tolerance Conics with very large w values can be approximated with two straight lines. This avoids iterating endlessly in an attempt to create quadratics with unstable numerics. Check to see if the first chop generated a pair of lines within the default point comparison tolerance. R=reed@google.com BUG=643933, 643665 GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2312923002 Committed: https://skia.googlesource.com/skia/+/e97fe839728aa77a413353395b5a4c94c4c1d931

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -1 line) Patch
M src/core/SkGeometry.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M tests/PathTest.cpp View 2 chunks +20 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
caryclark
4 years, 3 months ago (2016-09-06 14:23:46 UTC) #3
caryclark
this CL causes no gold changes
4 years, 3 months ago (2016-09-06 15:02:20 UTC) #7
reed1
lgtm
4 years, 3 months ago (2016-09-06 15:47:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312923002/1
4 years, 3 months ago (2016-09-06 15:52:58 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 15:54:13 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e97fe839728aa77a413353395b5a4c94c4c1d931

Powered by Google App Engine
This is Rietveld 408576698