Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Issue 2312913002: Better access to offline login flow from user pods (Closed)

Created:
4 years, 3 months ago by Greg Levin
Modified:
4 years, 3 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Better access to offline login flow from user pods BUG=641001 TEST=With device off-line, click Add person, check that "sign in as an existing user" link is at the bottom of the "Network not available" page, and sign in using this link. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2298073003 Cr-Commit-Position: refs/heads/master@{#416295} (cherry picked from commit a2b7b5a5d5bde185d6c1f803919ed551676ba6b6) Committed: https://chromium.googlesource.com/chromium/src/+/e2aa35f4ede6094776c9e6849079195a1623c79a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 3 chunks +1 line, -13 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
Greg Levin
4 years, 3 months ago (2016-09-06 14:14:46 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e2aa35f4ede6094776c9e6849079195a1623c79a.

Powered by Google App Engine
This is Rietveld 408576698