Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2270)

Unified Diff: content/renderer/render_widget.cc

Issue 23129015: Initialize RenderWidget(Host)(View)s with correct visibility state (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 0b206c7eb3a82df799f9f4a2274b54c34700d96a..773f37f146ff5358469ee7c64305065a51d0a1ef 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -34,7 +34,6 @@
#include "content/renderer/ime_event_guard.h"
#include "content/renderer/pepper/pepper_plugin_instance_impl.h"
#include "content/renderer/render_process.h"
-#include "content/renderer/render_process_visibility_manager.h"
#include "content/renderer/render_thread_impl.h"
#include "content/renderer/renderer_webkitplatformsupport_impl.h"
#include "ipc/ipc_sync_message.h"
@@ -188,7 +187,8 @@ namespace content {
RenderWidget::RenderWidget(WebKit::WebPopupType popup_type,
const WebKit::WebScreenInfo& screen_info,
- bool swapped_out)
+ bool swapped_out,
+ bool hidden)
: routing_id_(MSG_ROUTING_NONE),
surface_id_(0),
webwidget_(NULL),
@@ -204,7 +204,7 @@ RenderWidget::RenderWidget(WebKit::WebPopupType popup_type,
using_asynchronous_swapbuffers_(false),
num_swapbuffers_complete_pending_(0),
did_show_(false),
- is_hidden_(false),
+ is_hidden_(hidden),
is_fullscreen_(false),
needs_repainting_on_restore_(false),
has_focus_(false),
@@ -238,8 +238,6 @@ RenderWidget::RenderWidget(WebKit::WebPopupType popup_type,
is_threaded_compositing_enabled_ =
CommandLine::ForCurrentProcess()->HasSwitch(
switches::kEnableThreadedCompositing);
-
- RenderProcessVisibilityManager::GetInstance()->WidgetVisibilityChanged(true);
sky 2013/08/19 20:21:47 How come we now longer need to invoke this?
}
RenderWidget::~RenderWidget() {
@@ -264,7 +262,7 @@ RenderWidget* RenderWidget::Create(int32 opener_id,
const WebKit::WebScreenInfo& screen_info) {
DCHECK(opener_id != MSG_ROUTING_NONE);
scoped_refptr<RenderWidget> widget(
- new RenderWidget(popup_type, screen_info, false));
+ new RenderWidget(popup_type, screen_info, false, false));
if (widget->Init(opener_id)) { // adds reference on success.
return widget.get();
}
@@ -312,6 +310,8 @@ bool RenderWidget::DoInit(int32 opener_id,
// Take a reference on behalf of the RenderThread. This will be balanced
// when we receive ViewMsg_Close.
AddRef();
+ if (is_hidden_)
+ RenderThread::Get()->WidgetHidden();
return true;
} else {
// The above Send can fail when the tab is closing.

Powered by Google App Engine
This is Rietveld 408576698