Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Unified Diff: runtime/vm/disassembler_ia32.cc

Issue 23129014: Add packed add and subtract to IA32 and X64 assemblers (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/disassembler_x64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_ia32.cc
diff --git a/runtime/vm/disassembler_ia32.cc b/runtime/vm/disassembler_ia32.cc
index 5f1131e3b046a4264752acee3920ca6f829c6be7..a4d6bc49fd7aba450f37e1b52e68557c31d16720 100644
--- a/runtime/vm/disassembler_ia32.cc
+++ b/runtime/vm/disassembler_ia32.cc
@@ -1505,16 +1505,7 @@ int X86Decoder::InstructionDecode(uword pc) {
PrintCPURegister(regop);
} else if (*data == 0x0F) {
data++;
- if (*data == 0x2F) {
- data++;
- int mod, regop, rm;
- GetModRm(*data, &mod, &regop, &rm);
- Print("comisd ");
- PrintXmmRegister(regop);
- Print(",");
- PrintXmmRegister(rm);
- data++;
- } else if (*data == 0X6E) {
+ if (*data == 0X6E) {
data++;
int mod, regop, rm;
GetModRm(*data, &mod, &regop, &rm);
@@ -1609,8 +1600,20 @@ int X86Decoder::InstructionDecode(uword pc) {
Print(",");
PrintXmmRegister(rm);
data += 2;
+ } else if ((*data == 0xFE) || (*data == 0xFA) || (*data == 0x2F)) {
+ const char* mnemonic = NULL;
+ if (*data == 0xFE) mnemonic = "paddd ";
+ if (*data == 0xFA) mnemonic = "psubd ";
+ if (*data == 0x2F) mnemonic = "comisd ";
+ int mod, regop, rm;
+ GetModRm(*(data+1), &mod, &regop, &rm);
+ Print(mnemonic);
+ PrintXmmRegister(regop);
+ Print(",");
+ PrintXmmRegister(rm);
+ data += 2;
} else {
- UNIMPLEMENTED();
+ UNIMPLEMENTED();
}
} else if (*data == 0x90) {
data++;
« no previous file with comments | « runtime/vm/assembler_x64_test.cc ('k') | runtime/vm/disassembler_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698