Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: chrome/browser/sync/glue/shared_change_processor.cc

Issue 23129007: sync: Add GetAllSyncData to sync/api (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/shared_change_processor.cc
diff --git a/chrome/browser/sync/glue/shared_change_processor.cc b/chrome/browser/sync/glue/shared_change_processor.cc
index abe7070867a8eb6ff0b41d037498adccda088034..8b4e26adbeb26e7f4d1e8522467eddb791ff76e6 100644
--- a/chrome/browser/sync/glue/shared_change_processor.cc
+++ b/chrome/browser/sync/glue/shared_change_processor.cc
@@ -89,22 +89,6 @@ bool SharedChangeProcessor::Disconnect() {
return was_connected;
}
-syncer::SyncError SharedChangeProcessor::GetSyncData(
- syncer::SyncDataList* current_sync_data) {
- DCHECK(backend_loop_.get());
- DCHECK(backend_loop_->BelongsToCurrentThread());
- AutoLock lock(monitor_lock_);
- if (disconnected_) {
- syncer::SyncError error(FROM_HERE,
- syncer::SyncError::DATATYPE_ERROR,
- "Change processor disconnected.",
- type_);
- return error;
- }
- return generic_change_processor_->GetSyncDataForType(type_,
- current_sync_data);
-}
-
int SharedChangeProcessor::GetSyncCount() {
DCHECK(backend_loop_.get());
DCHECK(backend_loop_->BelongsToCurrentThread());
@@ -135,6 +119,29 @@ syncer::SyncError SharedChangeProcessor::ProcessSyncChanges(
from_here, list_of_changes);
}
+syncer::SyncDataList SharedChangeProcessor::GetAllSyncData(
+ syncer::ModelType type) const {
+ syncer::SyncDataList data;
+ GetAllSyncDataReturnError(type, &data); // Handles the disconnect case.
+ return data;
+}
+
+syncer::SyncError SharedChangeProcessor::GetAllSyncDataReturnError(
+ syncer::ModelType type,
+ syncer::SyncDataList* data) const {
+ DCHECK(backend_loop_.get());
+ DCHECK(backend_loop_->BelongsToCurrentThread());
+ AutoLock lock(monitor_lock_);
+ if (disconnected_) {
+ syncer::SyncError error(FROM_HERE,
+ syncer::SyncError::DATATYPE_ERROR,
+ "Change processor disconnected.",
+ type_);
+ return error;
+ }
+ return generic_change_processor_->GetAllSyncDataReturnError(type, data);
+}
+
bool SharedChangeProcessor::SyncModelHasUserCreatedNodes(bool* has_nodes) {
DCHECK(backend_loop_.get());
DCHECK(backend_loop_->BelongsToCurrentThread());
« no previous file with comments | « chrome/browser/sync/glue/shared_change_processor.h ('k') | chrome/browser/sync/glue/shared_change_processor_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698