Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc

Issue 23129007: sync: Add GetAllSyncData to sync/api (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review comments Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc b/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
index a4053509686c0259f3112499b53837fce55b1932..e20e7e868b74541373c46d66259aec0268594905 100644
--- a/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/non_ui_data_type_controller_unittest.cc
@@ -204,7 +204,7 @@ class SyncNonUIDataTypeControllerTest : public testing::Test {
EXPECT_CALL(*change_processor_.get(), ActivateDataType(_));
EXPECT_CALL(*change_processor_.get(), SyncModelHasUserCreatedNodes(_))
.WillOnce(DoAll(SetArgumentPointee<0>(true), Return(true)));
- EXPECT_CALL(*change_processor_.get(), GetSyncData(_))
+ EXPECT_CALL(*change_processor_.get(), GetAllSyncDataReturnError(_,_))
.WillOnce(Return(syncer::SyncError()));
EXPECT_CALL(*change_processor_.get(), GetSyncCount()).WillOnce(Return(0));
EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
@@ -275,7 +275,7 @@ TEST_F(SyncNonUIDataTypeControllerTest, StartFirstRun) {
.WillOnce(Return(true));
EXPECT_CALL(*change_processor_.get(), SyncModelHasUserCreatedNodes(_))
.WillOnce(DoAll(SetArgumentPointee<0>(false), Return(true)));
- EXPECT_CALL(*change_processor_.get(), GetSyncData(_))
+ EXPECT_CALL(*change_processor_.get(), GetAllSyncDataReturnError(_,_))
.WillOnce(Return(syncer::SyncError()));
EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
SetActivateExpectations(DataTypeController::OK_FIRST_RUN);
@@ -315,7 +315,7 @@ TEST_F(SyncNonUIDataTypeControllerTest, StartAssociationFailed) {
.WillOnce(Return(true));
EXPECT_CALL(*change_processor_.get(), SyncModelHasUserCreatedNodes(_))
.WillOnce(DoAll(SetArgumentPointee<0>(true), Return(true)));
- EXPECT_CALL(*change_processor_.get(), GetSyncData(_))
+ EXPECT_CALL(*change_processor_.get(), GetAllSyncDataReturnError(_,_))
.WillOnce(Return(syncer::SyncError()));
EXPECT_CALL(*dtc_mock_.get(), RecordAssociationTime(_));
SetStartFailExpectations(DataTypeController::ASSOCIATION_FAILED);
@@ -382,11 +382,12 @@ TEST_F(SyncNonUIDataTypeControllerTest, AbortDuringAssociation) {
WaitOnEvent(&pause_db_thread),
SetArgumentPointee<0>(true),
Return(true)));
- EXPECT_CALL(*change_processor_.get(), GetSyncData(_)).WillOnce(
- Return(syncer::SyncError(FROM_HERE,
- syncer::SyncError::DATATYPE_ERROR,
- "Disconnected.",
- AUTOFILL_PROFILE)));
+ EXPECT_CALL(*change_processor_.get(), GetAllSyncDataReturnError(_,_))
+ .WillOnce(
+ Return(syncer::SyncError(FROM_HERE,
+ syncer::SyncError::DATATYPE_ERROR,
+ "Disconnected.",
+ AUTOFILL_PROFILE)));
EXPECT_CALL(*change_processor_.get(), Disconnect())
.WillOnce(DoAll(SignalEvent(&pause_db_thread), Return(true)));
EXPECT_CALL(service_, DeactivateDataType(_));
« no previous file with comments | « chrome/browser/sync/glue/non_ui_data_type_controller.cc ('k') | chrome/browser/sync/glue/shared_change_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698