sync: Add GetAllSyncData to sync/api

sync/api/sync_change_processor.h

Index: sync/api/sync_change_processor.h
diff --git a/sync/api/sync_change_processor.h b/sync/api/sync_change_processor.h
index c2dad3f906570cf9cb1acf20695569c8ecc3acfe..69494f0849ca42f6b8e9dd9760aa39073de06594 100644
--- a/sync/api/sync_change_processor.h
+++ b/sync/api/sync_change_processor.h
@@ -7,8 +7,10 @@
 
 #include <vector>
 
+#include "sync/api/sync_data.h"
 #include "sync/api/sync_error.h"
 #include "sync/base/sync_export.h"
+#include "sync/internal_api/public/base/model_type.h"
 
 namespace tracked_objects {
 class Location;
@@ -36,6 +38,14 @@ class SYNC_EXPORT SyncChangeProcessor {
   virtual SyncError ProcessSyncChanges(
       const tracked_objects::Location& from_here,
       const SyncChangeList& change_list) = 0;
+
+  // Fills a list of SyncData. This should create an up to date representation
+  // of all the data known to the ChangeProcessor for |datatype|, and
+  // should match/be a subset of the server's view of that datatype.
+  //
+  // WARNING: This can be a potentially slow & memory intensive operation and
+  // should only be used when absolutely necessary / sparingly.
+  virtual SyncDataList GetAllSyncData(ModelType type) const = 0;

[haitaol1, 2013/08/19 17:11:04]

Should we care about error?

[tim (not reviewing), 2013/08/19 18:03:08]

I'm not sure it's worthwhile? My basic thinking was that I wanted to keep the
API the same in both (sync/native) directions, and we didn't have an error here
before.

[haitaol1, 2013/08/19 21:20:06]

ProcessSyncChanges() returns error. SyncableService::GetAllSyncData() doesn't
return error but it seems to be called only in tests. Without knowing error,
will caller destroy local model if seeing empty list?


On 2013/08/19 18:03:08, timsteele wrote:

 };
 
 }  // namespace syncer