sync: Add GetAllSyncData to sync/api

sync/api/syncable_service.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SYNC_API_SYNCABLE_SERVICE_H_
 #define SYNC_API_SYNCABLE_SERVICE_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 38 matching lines @@
   //          may also contain optional merge statistics.
   virtual SyncMergeResult MergeDataAndStartSyncing(
       ModelType type,
       const SyncDataList& initial_sync_data,
       scoped_ptr<SyncChangeProcessor> sync_processor,
       scoped_ptr<SyncErrorFactory> error_handler) = 0;
 
   // Stop syncing the specified type and reset state.
   virtual void StopSyncing(ModelType type) = 0;
 
-  // Fills a list of SyncData from the local data. This should create an up
-  // to date representation of the SyncableService's view of that datatype, and
-  // should match/be a subset of the server's view of that datatype.
-  virtual SyncDataList GetAllSyncData(ModelType type) const = 0;

[haitaol1, 2013/08/19 17:11:04]

Should this also be removed from subclasses of SyncableService?

[tim (not reviewing), 2013/08/19 18:03:08]

Note that I've really only moved this method up into the superclass, so
SyncableServices still need to implement.  SyncableService is a
SyncChangeProcessor.

-
   // SyncChangeProcessor interface.
   // Process a list of new SyncChanges and update the local data as necessary.
   // Returns: A default SyncError (IsSet() == false) if no errors were
   //          encountered, and a filled SyncError (IsSet() == true)
   //          otherwise.
   virtual SyncError ProcessSyncChanges(
       const tracked_objects::Location& from_here,
       const SyncChangeList& change_list) OVERRIDE = 0;
 
  protected:
   virtual ~SyncableService();
 };
 
 }  // namespace syncer
 
 #endif  // SYNC_API_SYNCABLE_SERVICE_H_