sync: Add GetAllSyncData to sync/api

chrome/browser/sync/glue/generic_change_processor_unittest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/sync/glue/generic_change_processor.h"
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/strings/stringprintf.h"
@@ skipping 75 matching lines @@
   syncer::FakeSyncableService fake_syncable_service_;
   base::WeakPtrFactory<syncer::FakeSyncableService>
       syncable_service_ptr_factory_;
 
   DataTypeErrorHandlerMock data_type_error_handler_;
   syncer::TestUserShare test_user_share_;
 
   scoped_ptr<GenericChangeProcessor> change_processor_;
 };
 
-// This test exercises GenericChangeProcessor's GetSyncDataForType function.
-// It's not a great test, but, by modifying some of the parameters, you could
-// turn it into a micro-benchmark for model association.
-TEST_F(SyncGenericChangeProcessorTest, StressGetSyncDataForType) {
+// Similar to above, but focused on the method that implements sync/api
+// interfaces and is hence exposed to datatypes directly.
+TEST_F(SyncGenericChangeProcessorTest, StressGetAllSyncData) {
   const int kNumChildNodes = 1000;
   const int kRepeatCount = 1;
 
   ASSERT_NO_FATAL_FAILURE(BuildChildNodes(kNumChildNodes));
 
   for (int i = 0; i < kRepeatCount; ++i) {
-    syncer::SyncDataList sync_data;
-    change_processor()->GetSyncDataForType(kType, &sync_data);
+    syncer::SyncDataList sync_data =
+        change_processor()->GetAllSyncData(kType);
 
     // Start with a simple test.  We can add more in-depth testing later.
     EXPECT_EQ(static_cast<size_t>(kNumChildNodes), sync_data.size());
   }
 }
 
 TEST_F(SyncGenericChangeProcessorTest, SetGetPasswords) {
   const int kNumPasswords = 10;
   sync_pb::PasswordSpecificsData password_data;
   password_data.set_username_value("user");
@@ skipping 11 matching lines @@
                            syncer::SyncChange::ACTION_ADD,
                            syncer::SyncData::CreateLocalData(
                                base::StringPrintf("tag%i", i),
                                base::StringPrintf("title%i", i),
                                password_holder)));
   }
 
   ASSERT_FALSE(
       change_processor()->ProcessSyncChanges(FROM_HERE, change_list).IsSet());
 
-  syncer::SyncDataList password_list;
-  ASSERT_FALSE(
-      change_processor()->GetSyncDataForType(syncer::PASSWORDS, &password_list).
-          IsSet());
+  syncer::SyncDataList password_list(
+      change_processor()->GetAllSyncData(syncer::PASSWORDS));
 
   ASSERT_EQ(password_list.size(), change_list.size());
   for (int i = 0; i < kNumPasswords; ++i) {
     // Verify the password is returned properly.
     ASSERT_TRUE(password_list[i].GetSpecifics().has_password());
     ASSERT_TRUE(password_list[i].GetSpecifics().password().
                     has_client_only_encrypted_data());
     ASSERT_FALSE(password_list[i].GetSpecifics().password().has_encrypted());
     const sync_pb::PasswordSpecificsData& sync_password =
         password_list[i].GetSpecifics().password().client_only_encrypted_data();
@@ skipping 49 matching lines @@
                                base::StringPrintf("tag%i", i),
                                base::StringPrintf("title_m%i", i),
                                password_holder)));
   }
 
   ASSERT_FALSE(
       change_processor()->ProcessSyncChanges(FROM_HERE, change_list).IsSet());
   ASSERT_FALSE(
       change_processor()->ProcessSyncChanges(FROM_HERE, change_list2).IsSet());
 
-  syncer::SyncDataList password_list;
-  ASSERT_FALSE(
-      change_processor()->GetSyncDataForType(syncer::PASSWORDS, &password_list).
-          IsSet());
+  syncer::SyncDataList password_list(
+      change_processor()->GetAllSyncData(syncer::PASSWORDS));
 
   ASSERT_EQ(password_list.size(), change_list2.size());
   for (int i = 0; i < kNumPasswords; ++i) {
     // Verify the password is returned properly.
     ASSERT_TRUE(password_list[i].GetSpecifics().has_password());
     ASSERT_TRUE(password_list[i].GetSpecifics().password().
                     has_client_only_encrypted_data());
     ASSERT_FALSE(password_list[i].GetSpecifics().password().has_encrypted());
     const sync_pb::PasswordSpecificsData& sync_password =
         password_list[i].GetSpecifics().password().client_only_encrypted_data();
@@ skipping 14 matching lines @@
     ASSERT_TRUE(raw_specifics.has_password());
     ASSERT_TRUE(raw_specifics.password().has_encrypted());
     ASSERT_FALSE(raw_specifics.password().has_client_only_encrypted_data());
   }
 }
 
 }  // namespace
 
 }  // namespace browser_sync