Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 2312863003: [api] Improve documentation for PropertyDeleterCallback. (Closed)

Created:
4 years, 3 months ago by Franzi
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[api] Improve documentation for PropertyDeleterCallback. BUG=v8:5260 Committed: https://crrev.com/ca6c87341f440742c42a4877f21a9354b88b95fe Cr-Commit-Position: refs/heads/master@{#39215}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -4 lines) Patch
M include/v8.h View 1 chunk +19 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Franzi
Last documentation CL for interceptors. With this I think we can close https://bugs.chromium.org/p/v8/issues/detail?id=5260 PTAL. Thanks, ...
4 years, 3 months ago (2016-09-06 13:46:17 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-09-06 15:04:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312863003/1
4 years, 3 months ago (2016-09-06 15:22:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-06 15:53:16 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 15:54:06 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ca6c87341f440742c42a4877f21a9354b88b95fe
Cr-Commit-Position: refs/heads/master@{#39215}

Powered by Google App Engine
This is Rietveld 408576698