Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 2312853005: Revert of [heap] Switch to 500k pages (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
Reviewers:
Michael Lippautz, ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [heap] Switch to 500k pages (patchset #5 id:80001 of https://codereview.chromium.org/2314803002/ ) Reason for revert: Breaks arm64 nosnap debug: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/2178 Original issue's description: > [heap] Switch to 500k pages > > BUG=chromium:636331 > R=ulan@chromium.org > > Committed: https://crrev.com/4b618dbf8ec7f0edf377b54b48bf3c852d5e235a > Cr-Commit-Position: refs/heads/master@{#39220} TBR=ulan@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:636331 Committed: https://crrev.com/332bd5e94c7b70d1d74d6ce1e9f86fee278740f6 Cr-Commit-Position: refs/heads/master@{#39229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M src/base/build_config.h View 1 chunk +1 line, -1 line 0 comments Download
M src/globals.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M src/heap/spaces.h View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/heap/test-heap.cc View 2 chunks +0 lines, -6 lines 0 comments Download
M test/cctest/heap/test-mark-compact.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [heap] Switch to 500k pages
4 years, 3 months ago (2016-09-07 06:31:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312853005/1
4 years, 3 months ago (2016-09-07 06:31:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-07 06:32:01 UTC) #5
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 06:32:33 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/332bd5e94c7b70d1d74d6ce1e9f86fee278740f6
Cr-Commit-Position: refs/heads/master@{#39229}

Powered by Google App Engine
This is Rietveld 408576698