Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Unified Diff: media/base/stream_parser.h

Issue 231283005: Add live mode detection in WebM MediaSource parser. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/base/stream_parser.h
diff --git a/media/base/stream_parser.h b/media/base/stream_parser.h
index 8123b4fc3d3deb3183261451e6b1f76ce9fea261..f406e68f0912c36b26754da08a20b0844b383ac9 100644
--- a/media/base/stream_parser.h
+++ b/media/base/stream_parser.h
@@ -49,21 +49,21 @@ class MEDIA_EXPORT StreamParser {
StreamParser();
virtual ~StreamParser();
- // Indicates completion of parser initialization.
- // First parameter - Indicates initialization success. Set to true if
- // initialization was successful. False if an error
- // occurred.
- // Second parameter - Indicates the stream duration. Only contains a valid
- // value if the first parameter is true.
- // Third parameter - Indicates the Time associated with
- // presentation timestamp 0 if such a mapping exists in
- // the bytestream. If no mapping exists this parameter
- // contains null Time object. Only contains a valid
- // value if the first parameter is true.
- // Fourth parameters - Indicates that timestampOffset should be updated based
- // on the earliest end timestamp (audio or video) provided
- // during each NewBuffersCB.
- typedef base::Callback<void(bool, base::TimeDelta, base::Time, bool)> InitCB;
+ // success - True if initialization was successful, false otherwise.
+ // duration - Stream duration. Only valid if |success| is true;
+ // timeline_offset - Indicates the source Time associated with
+ // presentation timestamp 0. A null Time is returned if
+ // no mapping to Time exists. Only contains a
+ // valid value if |success| is true.
+ // auto_update_timestamp_offset -
+ // Indicates that timestampOffset should be updated based on the earliest
+ // end timestamp (audio or video) provided during each NewBuffersCB.
+ // live_mode - True when the stream is a live stream.
+ typedef base::Callback<void(bool success,
+ base::TimeDelta duration,
+ base::Time timeline_offset,
+ bool auto_update_timestamp_offset,
+ bool live_mode)> InitCB;
Sergey Ulanov 2014/04/24 02:55:14 IMO it's better to add a struct (e.g. StreamParame
acolwell GONE FROM CHROMIUM 2014/04/24 16:59:36 Yeah. We should probably have a struct at this poi
// Indicates when new stream configurations have been parsed.
// First parameter - The new audio configuration. If the config is not valid

Powered by Google App Engine
This is Rietveld 408576698