Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1020)

Unified Diff: chrome/browser/ui/login/login_prompt.cc

Issue 231283003: Password manager: introduce logging for the internals page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comments addressed Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index 37922269d3a081eda76bd60bd0ab5cb2e5dabab4..c15bd1866755af020808a15738c443acd61ded13 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -14,6 +14,7 @@
#include "chrome/browser/password_manager/chrome_password_manager_client.h"
#include "chrome/browser/prerender/prerender_contents.h"
#include "chrome/browser/tab_contents/tab_util.h"
+#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include "components/password_manager/core/browser/password_manager.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/notification_registrar.h"
@@ -135,7 +136,21 @@ void LoginHandler::SetAuth(const base::string16& username,
const base::string16& password) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
- if (TestAndSetAuthHandled())
+ scoped_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
+ if (password_manager_ && password_manager_->client()->IsLoggingActive()) {
+ logger.reset(new password_manager::BrowserSavePasswordProgressLogger(
+ password_manager_->client()));
+ logger->LogMessage(
+ autofill::SavePasswordProgressLogger::STRING_SET_AUTH_METHOD);
+ }
+
+ bool already_handled = TestAndSetAuthHandled();
+ if (logger) {
+ logger->LogBoolean(
+ autofill::SavePasswordProgressLogger::STRING_AUTHENTICATION_HANDLED,
+ already_handled);
+ }
+ if (already_handled)
return;
// Tell the password manager the credentials were submitted / accepted.
@@ -143,6 +158,11 @@ void LoginHandler::SetAuth(const base::string16& username,
password_form_.username_value = username;
password_form_.password_value = password;
password_manager_->ProvisionallySavePassword(password_form_);
+ if (logger) {
+ logger->LogPasswordForm(
+ autofill::SavePasswordProgressLogger::STRING_LOGINHANDLER_FORM,
+ password_form_);
+ }
}
// Calling NotifyAuthSupplied() directly instead of posting a task

Powered by Google App Engine
This is Rietveld 408576698