Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Unified Diff: components/password_manager/core/browser/password_manager.h

Issue 231283003: Password manager: introduce logging for the internals page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Further comments addressed + unrelated style changes split off to a different CL Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/password_manager/core/browser/password_manager.h
diff --git a/components/password_manager/core/browser/password_manager.h b/components/password_manager/core/browser/password_manager.h
index da52aca3d60fb997dfb9e2220be2faaa33212e4d..f04087983bfc2fa6f8c36c178bc8906400ff0cbd 100644
--- a/components/password_manager/core/browser/password_manager.h
+++ b/components/password_manager/core/browser/password_manager.h
@@ -30,6 +30,7 @@ class PrefRegistrySyncable;
namespace password_manager {
+class BrowserSavePasswordProgressLogger;
class PasswordManagerClient;
class PasswordManagerDriver;
class PasswordManagerTest;
@@ -114,9 +115,12 @@ class PasswordManager : public LoginModel {
};
// Log failure for UMA. Logs additional metrics if the |form_origin|
- // corresponds to one of the top, explicitly monitored websites.
+ // corresponds to one of the top, explicitly monitored websites. For some
+ // values of |failure| also sends logs to the internals page through |logger|,
+ // it |logger| is not NULL.
void RecordFailure(ProvisionalSaveFailure failure,
- const std::string& form_origin);
+ const std::string& form_origin,
+ BrowserSavePasswordProgressLogger* logger);
// Possibly set up FieldTrial for testing other possible usernames. This only
// happens if there are other_possible_usernames to be shown and the

Powered by Google App Engine
This is Rietveld 408576698