Password manager: introduce logging for the internals page

chrome/browser/ui/login/login_prompt.cc

Index: chrome/browser/ui/login/login_prompt.cc
diff --git a/chrome/browser/ui/login/login_prompt.cc b/chrome/browser/ui/login/login_prompt.cc
index 37922269d3a081eda76bd60bd0ab5cb2e5dabab4..17d021f16f689eed85b5be1af31cdbb38d530a6b 100644
--- a/chrome/browser/ui/login/login_prompt.cc
+++ b/chrome/browser/ui/login/login_prompt.cc
@@ -14,6 +14,7 @@
 #include "chrome/browser/password_manager/chrome_password_manager_client.h"
 #include "chrome/browser/prerender/prerender_contents.h"
 #include "chrome/browser/tab_contents/tab_util.h"
+#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
 #include "components/password_manager/core/browser/password_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_registrar.h"
@@ -32,6 +33,7 @@
 #include "ui/gfx/text_elider.h"
 
 using autofill::PasswordForm;
+using autofill::SavePasswordProgressLogger;

[Peter Kasting, 2014/04/24 20:51:15]

Nit: Prefer to avoid using directives unless they make the code noticeably more
readable (this really goes for the existing statements here too, but whatever)

[vabr (Chromium), 2014/04/25 09:38:47]

Fair enough, I removed the added "using" directive, as prefixing autofill:: to
SavePasswordProgressLogger below did not cause considerable changes.

 using content::BrowserThread;
 using content::NavigationController;
 using content::RenderViewHost;
@@ -135,7 +137,20 @@ void LoginHandler::SetAuth(const base::string16& username,
                            const base::string16& password) {
   DCHECK_CURRENTLY_ON(BrowserThread::UI);
 
-  if (TestAndSetAuthHandled())
+  scoped_ptr<password_manager::BrowserSavePasswordProgressLogger> logger;
+  if (password_manager_ && password_manager_->client()->IsLoggingActive()) {
+    logger.reset(new password_manager::BrowserSavePasswordProgressLogger(
+        password_manager_->client()));
+    logger->LogMessage(SavePasswordProgressLogger::STRING_SET_AUTH_METHOD);
+  }
+
+  bool already_handled = TestAndSetAuthHandled();
+  if (logger) {
+    logger->LogBoolean(
+        SavePasswordProgressLogger::STRING_AUTHENTICATION_HANDLED,
+        already_handled);
+  }
+  if (already_handled)
     return;
 
   // Tell the password manager the credentials were submitted / accepted.
@@ -143,6 +158,10 @@ void LoginHandler::SetAuth(const base::string16& username,
     password_form_.username_value = username;
     password_form_.password_value = password;
     password_manager_->ProvisionallySavePassword(password_form_);
+    if (logger) {
+      logger->LogPasswordForm(
+          SavePasswordProgressLogger::STRING_LOGINHANDLER_FORM, password_form_);
+    }
   }
 
   // Calling NotifyAuthSupplied() directly instead of posting a task