Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: mojo/public/js/validation_unittests.js

Issue 2312813002: Limit Mojo messages recursion depth (Closed)
Patch Set: Address more review comments Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 define([ 5 define([
6 "console", 6 "console",
7 "file", 7 "file",
8 "gin/test/expect", 8 "gin/test/expect",
9 "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom", 9 "mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom",
10 "mojo/public/js/buffer", 10 "mojo/public/js/buffer",
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
226 // TODO(hansmuller) Temporarily skipping array pointer overflow tests 226 // TODO(hansmuller) Temporarily skipping array pointer overflow tests
227 // because JS numbers are limited to 53 bits. 227 // because JS numbers are limited to 53 bits.
228 // TODO(yzshen) Skipping struct versioning tests (tests with "mthd11" 228 // TODO(yzshen) Skipping struct versioning tests (tests with "mthd11"
229 // in the name) because the feature is not supported in JS yet. 229 // in the name) because the feature is not supported in JS yet.
230 // TODO(yzshen) Skipping enum validation tests (tests with "enum" in the 230 // TODO(yzshen) Skipping enum validation tests (tests with "enum" in the
231 // name) because the feature is not supported in JS yet. crbug.com/581390 231 // name) because the feature is not supported in JS yet. crbug.com/581390
232 // TODO(rudominer): Temporarily skipping 'no-such-method', 232 // TODO(rudominer): Temporarily skipping 'no-such-method',
233 // 'invalid_request_flags', and 'invalid_response_flags' until additional 233 // 'invalid_request_flags', and 'invalid_response_flags' until additional
234 // logic in *RequestValidator and *ResponseValidator is ported from 234 // logic in *RequestValidator and *ResponseValidator is ported from
235 // cpp to js. 235 // cpp to js.
236 // TODO(crbug/640298): Implement max recursion depth for JS.
236 if (testFiles[i].indexOf("overflow") != -1 || 237 if (testFiles[i].indexOf("overflow") != -1 ||
237 testFiles[i].indexOf("mthd11") != -1 || 238 testFiles[i].indexOf("mthd11") != -1 ||
239 testFiles[i].indexOf("conformance_mthd19") != -1 ||
238 testFiles[i].indexOf("enum") != -1 || 240 testFiles[i].indexOf("enum") != -1 ||
239 testFiles[i].indexOf("no_such_method") != -1 || 241 testFiles[i].indexOf("no_such_method") != -1 ||
240 testFiles[i].indexOf("invalid_request_flags") != -1 || 242 testFiles[i].indexOf("invalid_request_flags") != -1 ||
241 testFiles[i].indexOf("invalid_response_flags") != -1) { 243 testFiles[i].indexOf("invalid_response_flags") != -1) {
242 console.log("[Skipping " + testFiles[i] + "]"); 244 console.log("[Skipping " + testFiles[i] + "]");
243 continue; 245 continue;
244 } 246 }
245 247
246 var testMessage = readTestMessage(testFiles[i]); 248 var testMessage = readTestMessage(testFiles[i]);
247 var handles = new Array(testMessage.handleCount); 249 var handles = new Array(testMessage.handleCount);
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
340 testConformanceMessageValidation(); 342 testConformanceMessageValidation();
341 testBoundsCheckMessageValidation(); 343 testBoundsCheckMessageValidation();
342 testResponseConformanceMessageValidation(); 344 testResponseConformanceMessageValidation();
343 testResponseBoundsCheckMessageValidation(); 345 testResponseBoundsCheckMessageValidation();
344 testIntegratedMessageHeaderValidation(); 346 testIntegratedMessageHeaderValidation();
345 testIntegratedResponseMessageValidation(); 347 testIntegratedResponseMessageValidation();
346 testIntegratedRequestMessageValidation(); 348 testIntegratedRequestMessageValidation();
347 349
348 this.result = "PASS"; 350 this.result = "PASS";
349 }); 351 });
OLDNEW
« no previous file with comments | « mojo/public/interfaces/bindings/tests/validation_test_interfaces.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698