src/globals.h - Issue 23128007: Visual Studio 2012 and later support the C++11 final keyword.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/globals.h

Issue 23128007: Visual Studio 2012 and later support the C++11 final keyword. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/globals.h

diff --git a/src/globals.h b/src/globals.h

index 2f78e4fc612c1d1b2a6fcf47ee710ce3a55813d1..96152fe4cdf4fbc1107be617d20288f456416a6a 100644

--- a/src/globals.h

+++ b/src/globals.h

@@ -360,10 +360,15 @@ F FUNCTION_CAST(Address addr) {

#elif defined(_MSC_VER)

+// Override control was added with Visual Studio 2005.

# if _MSC_VER >= 1400

+# if _MSC_VER >= 1700

+# define V8_HAVE_CXX11_FINAL

+# else

+// Visual Studio 2010 and earlier spell "final" as "sealed".

+# define V8_HAVE_MSVC_SEALED

+# endif

# define V8_HAVE_CXX11_OVERRIDE

-// MSVC currently spells "final" as "sealed".

-# define V8_HAVE_MSVC_SEALED

# endif

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »