Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3098)

Unified Diff: chrome/browser/resources/google_now/background.js

Issue 23128005: Bring windows with new tabs to foreground (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/google_now/background.js
diff --git a/chrome/browser/resources/google_now/background.js b/chrome/browser/resources/google_now/background.js
index d1d896aeac47868d8d22319306c5269cb8e01df8..4a6aa825280cd730d5863f1d2aec2bab14f4de0e 100644
--- a/chrome/browser/resources/google_now/background.js
+++ b/chrome/browser/resources/google_now/background.js
@@ -591,7 +591,9 @@ function onNotificationClicked(notificationId, selector) {
return;
instrumented.tabs.create({url: url}, function(tab) {
- if (!tab)
+ if (tab)
+ chrome.windows.update(tab.windowId, {focused: true});
+ else
chrome.windows.create({url: url});
rgustafson 2013/08/14 01:02:03 My concern is whether the same will happen with th
vadimt 2013/08/14 01:35:03 Done.
});
});
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698