Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Issue 2312743005: Make CPDF_ContentMarkData private to CPDF_ContentMark (Closed)

Created:
4 years, 3 months ago by Tom Sepez
Modified:
4 years, 3 months ago
Reviewers:
dsinclair
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Make CPDF_ContentMarkData private to CPDF_ContentMark Committed: https://pdfium.googlesource.com/pdfium/+/f692e8e33eb2e6811196170238471532edae6858

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -108 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_contentmark.h View 2 chunks +27 lines, -2 lines 0 comments Download
M core/fpdfapi/fpdf_page/cpdf_contentmark.cpp View 5 chunks +60 lines, -3 lines 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_contentmarkdata.h View 1 chunk +0 lines, -37 lines 0 comments Download
D core/fpdfapi/fpdf_page/cpdf_contentmarkdata.cpp View 1 chunk +0 lines, -63 lines 0 comments Download
M core/fpdfdoc/cpdf_occontext.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
Tom Sepez
Dan, for review.
4 years, 3 months ago (2016-09-06 19:11:05 UTC) #4
dsinclair
lgtm
4 years, 3 months ago (2016-09-06 19:23:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312743005/1
4 years, 3 months ago (2016-09-06 19:23:57 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 19:24:15 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/f692e8e33eb2e6811196170238471532edae...

Powered by Google App Engine
This is Rietveld 408576698