Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 2312743002: Revert of [regexp] Port RegExpConstructor (Closed)

Created:
4 years, 3 months ago by jgruber
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [regexp] Port RegExpConstructor (patchset #2 id:20001 of https://codereview.chromium.org/2302773002/ ) Reason for revert: Performance regressions: crbug.com/644087 Clusterfuzz: crbug.com/644074 We'll reland all regexp changes at once when the port is complete and at least performance-neutral, since the partial port requires slow workarounds. Original issue's description: > [regexp] Port RegExpConstructor > > BUG=v8:5339 > > Committed: https://crrev.com/0aa80be16b8d876999066545c2922e1291e09610 > Cr-Commit-Position: refs/heads/master@{#39074} TBR=bmeurer@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=v8:5339 Committed: https://crrev.com/433c9ee77e19d0eb2133bae56d3ef98496f20f8d Cr-Commit-Position: refs/heads/master@{#39177}

Patch Set 1 #

Patch Set 2 : Format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -178 lines) Patch
M BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download
M src/bootstrapper.cc View 1 1 chunk +3 lines, -13 lines 0 comments Download
M src/builtins/builtins.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
D src/builtins/builtins-regexp.cc View 1 chunk +0 lines, -152 lines 0 comments Download
M src/heap-symbols.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/js/regexp.js View 1 10 chunks +46 lines, -7 lines 0 comments Download
M src/v8.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
jgruber
Created Revert of [regexp] Port RegExpConstructor
4 years, 3 months ago (2016-09-05 13:54:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312743002/1
4 years, 3 months ago (2016-09-05 13:54:29 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23314)
4 years, 3 months ago (2016-09-05 13:57:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312743002/200001
4 years, 3 months ago (2016-09-05 14:04:11 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:200001)
4 years, 3 months ago (2016-09-05 14:28:51 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 14:29:24 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/433c9ee77e19d0eb2133bae56d3ef98496f20f8d
Cr-Commit-Position: refs/heads/master@{#39177}

Powered by Google App Engine
This is Rietveld 408576698