Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Unified Diff: src/compiler/access-builder.cc

Issue 2312703002: [turbofan] Use MachineRepresentation for PropertyCell access. (Closed)
Patch Set: Nit. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/compiler/access-builder.cc
diff --git a/src/compiler/access-builder.cc b/src/compiler/access-builder.cc
index be1396b28f97508b18c0074c66b75b6a8e9e5648..54de75cfca48dccefc760a536ac2bb996b65a074 100644
--- a/src/compiler/access-builder.cc
+++ b/src/compiler/access-builder.cc
@@ -609,29 +609,6 @@ FieldAccess AccessBuilder::ForContextSlot(size_t index) {
return access;
}
-
-// static
-FieldAccess AccessBuilder::ForPropertyCellValue() {
- return ForPropertyCellValue(Type::Tagged());
-}
-
-
-// static
-FieldAccess AccessBuilder::ForPropertyCellValue(Type* type) {
- // Extract representation dimension of {type} into MachineType {r}.
- MachineType r = MachineType::AnyTagged();
- WriteBarrierKind w = kFullWriteBarrier;
- if (type->Is(Type::TaggedSigned())) {
- r = MachineType::TaggedSigned();
- w = kNoWriteBarrier;
- } else if (type->Is(Type::TaggedPointer())) {
- r = MachineType::TaggedPointer();
- }
- FieldAccess access = {
- kTaggedBase, PropertyCell::kValueOffset, Handle<Name>(), type, r, w};
- return access;
-}
-
// static
ElementAccess AccessBuilder::ForFixedArrayElement() {
ElementAccess access = {kTaggedBase, FixedArray::kHeaderSize, Type::Tagged(),

Powered by Google App Engine
This is Rietveld 408576698