Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2312703002:
[turbofan] Use MachineRepresentation for PropertyCell access. (Closed)
Description[turbofan] Use MachineRepresentation for PropertyCell access.
And not the Representation dimension of Type*.
BUG=
Committed: https://crrev.com/7b2a211b8e3bcf9422b2f1e87b729f8eff5207e8
Cr-Commit-Position: refs/heads/master@{#39179}
Patch Set 1 #Patch Set 2 : Nit. #
Total comments: 6
Patch Set 3 : REBASE, comments. #Patch Set 4 : Missed a fix. #Patch Set 5 : nit. #
Messages
Total messages: 30 (18 generated)
The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
mvstanton@chromium.org changed reviewers: + bmeurer@chromium.org
Hi Benedikt, Here are the improvements as we discussed, thx! --Mike
https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... File src/compiler/js-global-object-specialization.cc (right): https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... src/compiler/js-global-object-specialization.cc:51: static FieldAccess ForPropertyCellValue(MachineRepresentation representation, Nit: Put this into an anonymous namespace instead of using static here. https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... src/compiler/js-global-object-specialization.cc:56: } You can use kPointerWriteBarrier for kTaggedPointer.
https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... File src/compiler/js-global-object-specialization.cc (right): https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... src/compiler/js-global-object-specialization.cc:220: property_cell_value_type = Type::Number(); Type::SignedSmall here.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_chromium_gn_rel on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_chromium_gn_rel/bu...)
The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run
The CQ bit was checked by mvstanton@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. Committers are members of the group "project-v8-committers". Note that this has nothing to do with OWNERS files.
thx for comments... https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... File src/compiler/js-global-object-specialization.cc (right): https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... src/compiler/js-global-object-specialization.cc:51: static FieldAccess ForPropertyCellValue(MachineRepresentation representation, On 2016/09/05 12:10:48, Benedikt Meurer wrote: > Nit: Put this into an anonymous namespace instead of using static here. Done. https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... src/compiler/js-global-object-specialization.cc:56: } On 2016/09/05 12:10:48, Benedikt Meurer wrote: > You can use kPointerWriteBarrier for kTaggedPointer. Done. https://codereview.chromium.org/2312703002/diff/20001/src/compiler/js-global-... src/compiler/js-global-object-specialization.cc:220: property_cell_value_type = Type::Number(); On 2016/09/05 12:12:27, Benedikt Meurer wrote: > Type::SignedSmall here. Done.
mstarzinger@chromium.org changed reviewers: + mstarzinger@chromium.org
LGTM (rubber-stamped).
The CQ bit was checked by mvstanton@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/23304)
The CQ bit was checked by mvstanton@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by mvstanton@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mstarzinger@chromium.org Link to the patchset: https://codereview.chromium.org/2312703002/#ps80001 (title: "nit.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #5 (id:80001)
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Use MachineRepresentation for PropertyCell access. And not the Representation dimension of Type*. BUG= ========== to ========== [turbofan] Use MachineRepresentation for PropertyCell access. And not the Representation dimension of Type*. BUG= Committed: https://crrev.com/7b2a211b8e3bcf9422b2f1e87b729f8eff5207e8 Cr-Commit-Position: refs/heads/master@{#39179} ==========
Message was sent while issue was closed.
Patchset 5 (id:??) landed as https://crrev.com/7b2a211b8e3bcf9422b2f1e87b729f8eff5207e8 Cr-Commit-Position: refs/heads/master@{#39179} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
