Switch Google Now Background Toggle to use Experiment Variations

chrome/browser/resources/google_now/background.js

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @fileoverview The event page for Google Now for Chrome implementation.
  * The Google Now event page gets Google Now cards from the server and shows
  * them as Chrome notifications.
@@ skipping 100 matching lines @@
     return true;
   }
 
   return false;
 }
 
 var tasks = buildTaskManager(areTasksConflicting);
 
 // Add error processing to API calls.
 tasks.instrumentChromeApiFunction('location.onLocationUpdate.addListener', 0);
-tasks.instrumentChromeApiFunction('metricsPrivate.getFieldTrial', 1);
 tasks.instrumentChromeApiFunction('metricsPrivate.getVariationParams', 1);
 tasks.instrumentChromeApiFunction('notifications.create', 2);
 tasks.instrumentChromeApiFunction('notifications.update', 2);
 tasks.instrumentChromeApiFunction('notifications.getAll', 0);
 tasks.instrumentChromeApiFunction(
     'notifications.onButtonClicked.addListener', 0);
 tasks.instrumentChromeApiFunction('notifications.onClicked.addListener', 0);
 tasks.instrumentChromeApiFunction('notifications.onClosed.addListener', 0);
 tasks.instrumentChromeApiFunction('omnibox.onInputEntered.addListener', 0);
 tasks.instrumentChromeApiFunction(
@@ skipping 729 matching lines @@
 
 /**
  * Coordinates the behavior of Google Now for Chrome depending on
  * Chrome and extension state.
  */
 function onStateChange() {
   tasks.add(STATE_CHANGED_TASK_NAME, function(callback) {
     tasks.debugSetStepName('onStateChange-isSignedIn');
     authenticationManager.isSignedIn(function(token) {
       var signedIn = !!token && !!NOTIFICATION_CARDS_URL;
-      instrumented.metricsPrivate.getFieldTrial(
+      instrumented.metricsPrivate.getVariationParams(
           'GoogleNow',
           function(response) {
-            console.log('Experiment Status: ' + response);
-            var enableBackground = (response != 'EnableWithoutBackground');
+            var enableBackground =
+                (response && (response.enableBackground != 'false'));

[vadimt, 2013/08/13 21:05:15]

!response || response.enableBackground != 'false'.

We want background to be the default.

[robliao, 2013/08/13 21:09:15]

That's a bit more permissive than I was expecting.

Which experiments will not include a variation param but still enable Google
Now?

If there's no response, we should treat it as an error, and not enable
background.

On 2013/08/13 21:05:15, vadimt wrote:

[vadimt, 2013/08/13 21:17:10]

Background is a "normal" behavior, and the absence of thereof is an anomaly that
we introduce to compare it with the normal behavior. If in doubt, it's better to
choose the normal behavior.

This is also a step towards being able to delete the experiment after it's not
needed anymore without having to wait till new Chrome build.

[robliao, 2013/08/13 21:30:32]

Done.

             tasks.debugSetStepName(
                 'onStateChange-get-googleGeolocationAccessEnabledPref');
             instrumented.
                 preferencesPrivate.
                 googleGeolocationAccessEnabled.
                 get({}, function(prefValue) {
                   var geolocationEnabled = !!prefValue.value;
                   tasks.debugSetStepName(
                     'onStateChange-get-userRespondedToToast');
                   instrumented.storage.local.get(
@@ skipping 99 matching lines @@
 
 instrumented.location.onLocationUpdate.addListener(function(position) {
   recordEvent(GoogleNowEvent.LOCATION_UPDATE);
   updateNotificationsCards(position);
 });
 
 instrumented.omnibox.onInputEntered.addListener(function(text) {
   localStorage['server_url'] = NOTIFICATION_CARDS_URL = text;
   initialize();
 });