Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Issue 2312693002: [turbofan] Math.random never produces -0. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Math.random never produces -0. R=mvstanton@chromium.org BUG=v8:5267, v8:5270 Committed: https://crrev.com/75d4db728b67395954bf85e531924f7e4e3a115e Cr-Commit-Position: refs/heads/master@{#39162}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler/typer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 3 months ago (2016-09-05 11:29:00 UTC) #1
Benedikt Meurer
Hey Michael, Here's a oneline improvement for the Math.random type. Please take a look. Thanks, ...
4 years, 3 months ago (2016-09-05 11:29:29 UTC) #4
mvstanton
Nice! LGTM.
4 years, 3 months ago (2016-09-05 11:34:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312693002/1
4 years, 3 months ago (2016-09-05 11:46:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 11:55:10 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 11:55:26 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/75d4db728b67395954bf85e531924f7e4e3a115e
Cr-Commit-Position: refs/heads/master@{#39162}

Powered by Google App Engine
This is Rietveld 408576698