Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2312683002: Include only stuff you need, part 7: Fix scopes.h -> ast.h. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Include only stuff you need, part 7: Fix scopes.h -> ast.h. Rebuilding (after touching certain files) is crazy slow because includes are out of control. BUG=v8:5294 Committed: https://crrev.com/7a6fb4d0e97832635d70bbacb552d52812ace710 Cr-Commit-Position: refs/heads/master@{#39161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -20 lines) Patch
M src/ast/scopes.h View 3 chunks +9 lines, -19 lines 0 comments Download
M src/ast/scopes.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M src/compilation-info.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/crankshaft/typing.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/parsing/parser-base.h View 1 chunk +1 line, -0 lines 0 comments Download
M test/unittests/compiler-dispatcher/compiler-dispatcher-job-unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Benedikt Meurer
lgtm
4 years, 3 months ago (2016-09-05 11:46:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312683002/1
4 years, 3 months ago (2016-09-05 11:48:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 11:54:04 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 11:54:42 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7a6fb4d0e97832635d70bbacb552d52812ace710
Cr-Commit-Position: refs/heads/master@{#39161}

Powered by Google App Engine
This is Rietveld 408576698