Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Issue 2312643003: [heap] Move PromotionQueue implementation out of heap.h (Closed)

Created:
4 years, 3 months ago by Michael Lippautz
Modified:
4 years, 3 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Move PromotionQueue implementation out of heap.h Move either in heap-inl.h or heap.cc, depending on the performance requirements. R=ulan@chromium.org Committed: https://crrev.com/936f596f2fa337802cafea36d653991ef70f0d5b Cr-Commit-Position: refs/heads/master@{#39184}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -84 lines) Patch
M src/heap/heap.h View 3 chunks +28 lines, -84 lines 1 comment Download
M src/heap/heap.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/heap/heap-inl.h View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
Michael Lippautz
ptal https://codereview.chromium.org/2312643003/diff/1/src/heap/heap.h File src/heap/heap.h (left): https://codereview.chromium.org/2312643003/diff/1/src/heap/heap.h#oldcode448 src/heap/heap.h:448: enum ArrayStorageAllocationMode { Moved up
4 years, 3 months ago (2016-09-05 16:10:11 UTC) #2
ulan
lgtm
4 years, 3 months ago (2016-09-05 16:39:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2312643003/1
4 years, 3 months ago (2016-09-05 16:40:50 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-05 16:42:27 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-09-05 16:43:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/936f596f2fa337802cafea36d653991ef70f0d5b
Cr-Commit-Position: refs/heads/master@{#39184}

Powered by Google App Engine
This is Rietveld 408576698