Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 23126008: WebCrypto: refactor layout tests. (Closed)

Created:
7 years, 4 months ago by eroman
Modified:
7 years, 4 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch
Visibility:
Public.

Description

WebCrypto: refactor the layout tests. Cleans up the layout tests to use a more idiomatic pattern for Promises. Before it was using a wrapper to serialize a set of async tests, whereas now it is creating a chain of Promises. This change also adds some additional tests for algorithm normalization. BUG=245025 R=abarth@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156487

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -330 lines) Patch
M LayoutTests/crypto/digest.html View 1 chunk +37 lines, -69 lines 0 comments Download
M LayoutTests/crypto/digest-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
A LayoutTests/crypto/encrypt-decrypt.html View 1 chunk +41 lines, -0 lines 0 comments Download
A LayoutTests/crypto/encrypt-decrypt-expected.txt View 1 chunk +15 lines, -0 lines 0 comments Download
M LayoutTests/crypto/generateKey.html View 3 chunks +48 lines, -35 lines 0 comments Download
M LayoutTests/crypto/generateKey-expected.txt View 1 chunk +19 lines, -4 lines 0 comments Download
M LayoutTests/crypto/importKey.html View 1 chunk +108 lines, -187 lines 0 comments Download
M LayoutTests/crypto/importKey-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/crypto/resources/common.js View 2 chunks +20 lines, -3 lines 0 comments Download
M LayoutTests/crypto/sign-verify.html View 1 chunk +50 lines, -25 lines 0 comments Download
M LayoutTests/crypto/sign-verify-expected.txt View 1 chunk +19 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
eroman
7 years, 4 months ago (2013-08-21 17:16:24 UTC) #1
abarth-chromium
lgtm Nice!
7 years, 4 months ago (2013-08-21 17:21:26 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/23126008/3001
7 years, 4 months ago (2013-08-21 17:21:35 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=2957
7 years, 4 months ago (2013-08-21 18:47:59 UTC) #4
eroman
7 years, 4 months ago (2013-08-21 19:10:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r156487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698