Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1166)

Issue 2312553002: Converted Observatory debugger elements (Closed)

Created:
4 years, 3 months ago by cbernaschina
Modified:
4 years, 3 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed isolatePaused() implementation #

Patch Set 3 : Fixed CSS and Crash during fast refresh #

Patch Set 4 : Fixed anyRef implementation for sentinels #

Patch Set 5 : Fixed isSampled setter implementation #

Patch Set 6 : Added shortName to Sentinel #

Patch Set 7 : Sharing command history and console #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1284 lines, -1006 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 chunks +8 lines, -1 line 0 comments Download
M runtime/observatory/lib/elements.html View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/lib/src/app/page.dart View 1 2 3 4 5 6 1 chunk +22 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/cli/command.dart View 1 2 3 4 5 6 2 chunks +9 lines, -3 lines 0 comments Download
M runtime/observatory/lib/src/debugger/debugger.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/src/elements/css/shared.css View 1 2 3 2 chunks +270 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/elements/debugger.dart View 1 2 3 4 5 6 45 chunks +971 lines, -510 lines 0 comments Download
D runtime/observatory/lib/src/elements/debugger.html View 1 chunk +0 lines, -478 lines 0 comments Download
M runtime/observatory/lib/src/elements/helpers/any_ref.dart View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (3 generated)
cbernaschina
4 years, 3 months ago (2016-09-04 19:32:16 UTC) #2
cbernaschina
Fixed subject and description
4 years, 3 months ago (2016-09-04 20:09:37 UTC) #4
cbernaschina
4 years, 3 months ago (2016-09-06 16:20:38 UTC) #5
cbernaschina
4 years, 3 months ago (2016-09-06 17:37:39 UTC) #6
cbernaschina
4 years, 3 months ago (2016-09-06 19:51:05 UTC) #7
cbernaschina
4 years, 3 months ago (2016-09-06 20:03:01 UTC) #8
rmacnak
lgtm
4 years, 3 months ago (2016-09-06 20:40:37 UTC) #9
cbernaschina
Debugger history and console are shared across components. In this way switching isolate will refresh ...
4 years, 3 months ago (2016-09-06 21:09:12 UTC) #10
turnidge
lgtm
4 years, 3 months ago (2016-09-06 21:09:27 UTC) #11
cbernaschina
4 years, 3 months ago (2016-09-06 22:05:52 UTC) #13
Message was sent while issue was closed.
Committed patchset #7 (id:120001) manually as
876f49999a37a5e1281867ec0e4a0e1917ac2a7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698